Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add track-specific information to Protein Translation. #109

Open
BNAndras opened this issue Aug 2, 2024 · 2 comments
Open

Add track-specific information to Protein Translation. #109

BNAndras opened this issue Aug 2, 2024 · 2 comments
Assignees
Labels
x:action/improve Improve existing functionality/content x:action/sync Sync content with its latest version x:rep/large Large amount of reputation

Comments

@BNAndras
Copy link
Member

BNAndras commented Aug 2, 2024

The Protein Translation exercise deviates from the upstream canonical data by including additional proteins not listed in the instructions. Generally, that's fine, but in this circumstance, students will likely get confused since this exercise is often marked as an easy or medium exercise, not a hard one. Also the instructions tab prominently says not all codon sequences and amino acids are important to the exercise. The table at the end is also introduced as showing all the codons and acids.

We shouldn't directly edit the instructions since it makes syncing upstream changes harder. configlet will just overwrite whatever's currently in the instructions so you'd need to add the info back manually. A better approach is to make an instructions.append.md file that includes track-specific content and is appended to the end of the instructions. There, it'd be good to include an updated table or just mention that the Cairo track is using more amino acids than what's in the initial table. That'll alert the student that they need to pay closer attention.

@0xNeshi
Copy link
Contributor

0xNeshi commented Aug 2, 2024

Everything except for the solution itself (lib.cairo and example.cairo) was copied from Rust's track, so I didn't modify much as I assumed everything's alright.

Will compare the canonical data with what we have, and update as per your suggestions.

@0xNeshi 0xNeshi self-assigned this Aug 30, 2024
@0xNeshi
Copy link
Contributor

0xNeshi commented Aug 30, 2024

Will rewrite the whole exercise to completely match the canonical data

@0xNeshi 0xNeshi added x:action/improve Improve existing functionality/content x:rep/large Large amount of reputation x:action/sync Sync content with its latest version labels Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/improve Improve existing functionality/content x:action/sync Sync content with its latest version x:rep/large Large amount of reputation
Projects
None yet
Development

No branches or pull requests

2 participants