cmd/submit_test.go: Update test server to use unmodified filename (#1115

)

Following RFC 7578, Go 1.17+ strips the directory information in fileHeader.Filename.
This change updates the test server to use Header["Content-Disposition"] for obtaining the unmodified filename
for validating the submitted files directory tree in the request.

This work builds on the PR opened by @QuLogic #1066

Co-authored-by: Erik Schierboom <erik_schierboom@hotmail.com>

cmd/submit_test.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io/ioutil"
+	"mime"
 	"net/http"
 	"net/http/httptest"
 	"os"
@@ -561,7 +562,16 @@ func fakeSubmitServer(t *testing.T, submittedFiles map[string]string) *httptest.
 			if err != nil {
 				t.Fatal(err)
 			}
-			submittedFiles[fileHeader.Filename] = string(body)
+			// Following RFC 7578, Go 1.17+ strips the directory information in fileHeader.Filename.
+			// Validating the submitted files directory tree is important so Content-Disposition is used for
+			// obtaining the unmodified filename.
+			v := fileHeader.Header.Get("Content-Disposition")
+			_, dispositionParams, err := mime.ParseMediaType(v)
+			if err != nil {
+				t.Fatalf("failed to obtain submitted filename from multipart header: %s", err.Error())
+			}
+			filename := dispositionParams["filename"]
+			submittedFiles[filename] = string(body)
 		}
 
 		fmt.Fprint(w, "{}")