Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footbal match reports exercise should depend on Exceptions first exercise #2306

Closed
jozolam opened this issue Sep 18, 2024 · 6 comments · Fixed by #2322
Closed

Footbal match reports exercise should depend on Exceptions first exercise #2306

jozolam opened this issue Sep 18, 2024 · 6 comments · Fixed by #2322

Comments

@jozolam
Copy link

jozolam commented Sep 18, 2024

Hello, I think that the football match exercise https://github.com/exercism/csharp/blob/main/exercises/concept/football-match-reports/.docs/instructions.md should depend on exceptions first exercise because you ask for a thrown exception. I would create PR but not sure where are dependencies defined.

Copy link
Contributor

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

@ErikSchierboom
Copy link
Member

Good catch! They're defined here: https://github.com/exercism/csharp/blob/main/config.json#L553-L557

@vaeng
Copy link
Contributor

vaeng commented Oct 29, 2024

The calculator conundrum exercises depend on the switch concept, which is the next concept after switch. To resolve this, the exception task from the football match has to be removed or the concept of exceptions should be explained in the football match exercise. I think the removal might be better, as exceptions are taught later in the syllabus and they are not needed here.

@ErikSchierboom
Copy link
Member

I think the removal might be better, as exceptions are taught later in the syllabus and they are not needed here.

I think we shouldn't remove it, but instead change it. The goal of that task is to "force" students to use a default case. So maybe we just change it to expect them to return a default string value instead.

@vaeng
Copy link
Contributor

vaeng commented Oct 29, 2024

****> So maybe we just change it to expect them to return a default string value instead.

Yes, I think that would make it more streamlined. Would you like me to open a pr?

@ErikSchierboom
Copy link
Member

Yes please!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants