Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify that tests actually implement the canonical tests #229

Open
23 of 27 tasks
fapdash opened this issue Oct 18, 2022 · 3 comments
Open
23 of 27 tasks

Verify that tests actually implement the canonical tests #229

fapdash opened this issue Oct 18, 2022 · 3 comments
Assignees
Labels
x:action/sync Sync content with its latest version

Comments

@fapdash
Copy link
Contributor

fapdash commented Oct 18, 2022

It seems that some of the tests don't implement the tests that they claim to implement in their meta/tests.toml, see #228.
Also some exercises don't implement all canonical tests according to the toml.
Find out which ones with configlet sync --tests or configlet sync --tests -e testname
We should go through all the exercises and verify.

@mkleehammer
Copy link

I would suggest the acronym tests be updated to include something with punctuation, such as the example from the readme: "Thank George It's Friday". Some of the community ones that passed would not pass this, which is not helpful for those learning from them.

@BNAndras
Copy link
Member

I would suggest the acronym tests be updated to include something with punctuation, such as the example from the readme: "Thank George It's Friday". Some of the community ones that passed would not pass this, which is not helpful for those learning from them.

There's a canonical test for Hailey's Comet that would take care of this once synced. I can take a look later this week.

@BNAndras
Copy link
Member

Atbash Cipher is missing the decoding half of the exercise so I'm separating that off into a separate issue for tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:action/sync Sync content with its latest version
Projects
None yet
Development

No branches or pull requests

3 participants