Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added nucleotide-count exercise. #45

Merged
merged 2 commits into from
Oct 5, 2016
Merged

Added nucleotide-count exercise. #45

merged 2 commits into from
Oct 5, 2016

Conversation

cpaulbond
Copy link
Contributor

Let me know if there are any problems.

@kytrinyx
Copy link
Member

So many pull requests! Thanks so much ❤️

I'm calling in reinforcements (... who actually know elisp). Hang on tight.

@kytrinyx
Copy link
Member

OK, just a heads up: it looks like @canweriotnow will come by this weekend and review the PRs.

@cpaulbond
Copy link
Contributor Author

No problem, I was having a good time and wanted to share. :-)

On Thu, Aug 11, 2016 at 7:36 PM, Katrina Owen notifications@github.com
wrote:

OK, just a heads up: it looks like @canweriotnow
https://github.com/canweriotnow will come by this weekend and review
the PRs.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#45 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AABVgOiGw3VEsCpQRRkOiakpGsr1cB57ks5qe7H-gaJpZM4JipVk
.

C. Paul Bond, cpaulbond@gmail.com

(let ((n (assoc i counts)))
(if n
(setcdr n (1+ (cdr n)))
(error "Unknown value '%c' %d" i i))))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to replace "Unknown value" with something like "Invalid nucleotide."

@yurrriq
Copy link
Member

yurrriq commented Aug 14, 2016

LGTM. If @canweriotnow doesn't get to it in the next couple days, I can merge.

@canweriotnow canweriotnow self-assigned this Oct 2, 2016
@canweriotnow canweriotnow merged commit 5b5c0f1 into exercism:master Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants