Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

destructure parameters #2507

Merged
merged 2 commits into from
Jul 24, 2024
Merged

destructure parameters #2507

merged 2 commits into from
Jul 24, 2024

Conversation

ConeDragon
Copy link
Contributor

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jul 13, 2024
@ConeDragon
Copy link
Contributor Author

In exercise notes, should there be a note that destructuring in the function itself is also acceptable?

@SleeplessByte SleeplessByte reopened this Jul 13, 2024
@SleeplessByte
Copy link
Member

In exercise notes, should there be a note that destructuring in the function itself is also acceptable?

That would be good. If you mentor this exercise it's a good opportunity to inform a student that in JavaScript you can do it directly in the parameter.

Copy link
Member

@SleeplessByte SleeplessByte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@SleeplessByte SleeplessByte added the x:size/small Small amount of work label Jul 24, 2024
@SleeplessByte SleeplessByte merged commit 00685d6 into exercism:main Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants