Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameters that conflict with security schemas #166

Conversation

ipepe
Copy link
Contributor

@ipepe ipepe commented Jan 8, 2024

Based on #160 I implemented a cleanup that removes parameters that conflict with defined security schemas.

TODO:

  • Write tests for this functionality

Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (71764c0) 96.69% compared to head (618e5e4) 96.80%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #166      +/-   ##
==========================================
+ Coverage   96.69%   96.80%   +0.11%     
==========================================
  Files          15       15              
  Lines         454      470      +16     
  Branches       97      102       +5     
==========================================
+ Hits          439      455      +16     
  Misses         15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

spec/requests/rails_spec.rb Fixed Show fixed Hide fixed
spec/rspec/rails_spec.rb Fixed Show fixed Hide fixed
spec/rspec/rails_spec.rb Fixed Show fixed Hide fixed
@ipepe ipepe marked this pull request as ready for review January 8, 2024 21:54
@ipepe
Copy link
Contributor Author

ipepe commented Jan 8, 2024

@exoego Please review

Copy link
Owner

@exoego exoego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM 💯

I will publish a new version within this week

@exoego exoego added the enhancement New feature or request label Jan 9, 2024
@exoego exoego merged commit 8b60147 into exoego:master Jan 9, 2024
14 checks passed
@ipepe ipepe deleted the issue-160/cleanup-parameters-from-securityschemes branch January 9, 2024 10:46
@exoego exoego changed the title Add RSpec::OpenAPI::SchemaCleaner.cleanup_conflicting_security_parameters! Remove parameters that conflict with security schemas Jan 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants