RSpec converts YAML files to Hash before comparison #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting idea. One of the benefits behind the original implementation was to be able to see what YAML changes are made by the current code locally, but given that we could see diffs on GitHub PRs and updating the YAML is not difficult without the diff either, this idea may be better. I might change my mind later, but let's try this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thank you for your nice tool.
I noticed the following failed test.
https://github.com/k0kubun/rspec-openapi/pull/22/checks?check_run_id=2051943034
I was able to reproduce it in my environment, too. The comparison of YAML files seems to be a bit buggy.
My idea is to convert the YAML files to Hash before the comparison.