Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup RuboCop #74

Merged
merged 3 commits into from
Oct 21, 2022
Merged

Setup RuboCop #74

merged 3 commits into from
Oct 21, 2022

Conversation

exoego
Copy link
Owner

@exoego exoego commented Aug 25, 2022

To reduce efforts on code format and code review, let's introduce RuboCop.

This PR fixes some warning-level code offenses.
Other minor offenses will be addressed in subsequent PRs.

@exoego exoego changed the title Setup Rubocop Setup Rubocop and fix warnings Aug 29, 2022
@exoego exoego changed the title Setup Rubocop and fix warnings Setup Rubocop Sep 12, 2022
@exoego exoego marked this pull request as ready for review September 12, 2022 01:16
@exoego exoego changed the title Setup Rubocop Setup RuboCop Sep 12, 2022
@exoego
Copy link
Owner Author

exoego commented Oct 21, 2022

I believe this eases us to maintain code quality.
We may configure RuboCop rules if we find them not so useful.

@exoego exoego merged commit fb50316 into master Oct 21, 2022
@exoego exoego deleted the rubocop-test branch October 21, 2022 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant