Refactor Coval Scoring code #10875
Merged
Refactor Coval Scoring code #10875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes some renames to make names less generic.
adrianeboyd
reviewed
May 30, 2022
|
Note: I'm going to go ahead and refactor the scorers into registered scorers in this PR too. |
polm
commented
May 31, 2022
svlandeg
added
feat / coref
Coref can't be loaded without Torch, so nothing works.
Some of this just involves ignoring types in thorny areas. Two main issues: 1. Some things have weird types due to indirection/ argskwargs 2. xp2torch return type seems to have changed at some point
polm
commented
Jun 3, 2022
|
I ended up fixing the tests (mostly by skipping when Torch isn't present) and types (mostly by ignoring or removing them) :/ . It is green now at least, and should be ready to merge in the coref branch for further cleanup. |
kadarakos
reviewed
Jun 8, 2022
Co-authored-by: kadarakos <kadar.akos@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This moves the scoring code that was taken from coval into
scorer.py, renames some things to be less generic, and adds the license to our list.Types of change
Refactor
Checklist