Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store activations in Docs when save_activations is enabled #11002

Merged
merged 42 commits into from
Sep 13, 2022

Commits on Jun 22, 2022

  1. Store activations in Doc when store_activations is enabled

    This change adds the new `activations` attribute to `Doc`. This
    attribute can be used by trainable pipes to store their activations,
    probabilities, and guesses for downstream users.
    
    As an example, this change modifies the `tagger` and `senter` pipes to
    add an `store_activations` option. When this option is enabled, the
    probabilities and guesses are stored in `set_annotations`.
    danieldk committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    b71c604 View commit details
    Browse the repository at this point in the history
  2. Change type of store_activations to Union[bool, List[str]]

    When the value is:
    
    - A bool: all activations are stored when set to `True`.
    - A List[str]: the activations named in the list are stored
    danieldk committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    c3da32b View commit details
    Browse the repository at this point in the history
  3. Formatting fixes in Tagger

    danieldk committed Jun 22, 2022
    Configuration menu
    Copy the full SHA
    789a447 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    acf47e8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    42526a6 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8772b9c View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2022

  1. Configuration menu
    Copy the full SHA
    1c9be0d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    009a960 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2022

  1. Extend tagger and senter tests

    So that they, like the other tests, also check that we get no
    activations if no activations were requested.
    danieldk committed Jun 24, 2022
    Configuration menu
    Copy the full SHA
    c8a12c5 View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2022

  1. Configuration menu
    Copy the full SHA
    508b96f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b13f17 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    df513be View commit details
    Browse the repository at this point in the history

Commits on Jul 6, 2022

  1. Start errors/warnings at higher numbers to avoid merge conflicts

    Between the master and v4 branches.
    danieldk committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    5eeb2e8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    403b1f1 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2022

  1. Configuration menu
    Copy the full SHA
    288d27e View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2022

  1. Replace store_activations setter by set_store_activations method

    Setters that take a different type than what the getter returns are still
    problematic for MyPy. Replace the setter by a method, so that type inference
    works everywhere.
    danieldk committed Aug 4, 2022
    Configuration menu
    Copy the full SHA
    51f72e4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6e7b958 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Revert "Use dict comprehension suggested by @svlandeg"

    This reverts commit 6e7b958.
    danieldk committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    230264d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    57caae8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ce36f34 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    75d76cb View commit details
    Browse the repository at this point in the history
  5. Apply suggestions from code review

    Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
    danieldk and svlandeg committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    c792019 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    1cfbb93 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Make the TrainablePipe.store_activations property a bool

    This means that we can also bring back `store_activations` setter.
    danieldk committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    aea5337 View commit details
    Browse the repository at this point in the history
  2. Remove TrainablePipe.activations

    We do not need to enumerate the activations anymore since `store_activations` is
    `bool`.
    danieldk committed Aug 29, 2022
    Configuration menu
    Copy the full SHA
    8c2652d View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Configuration menu
    Copy the full SHA
    8f84e6e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3937abd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2290a04 View commit details
    Browse the repository at this point in the history
  4. Error E1400 is not used anymore

    This error was used when activations were still `Union[bool, List[str]]`.
    danieldk committed Aug 30, 2022
    Configuration menu
    Copy the full SHA
    cdbda0b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    51c87c5 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d245da0 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    699a187 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6f80e80 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2022

  1. Rename activations

    - "probs" -> "probabilities"
    - "guesses" -> "label_ids", except in the edit tree lemmatizer, where
      "guesses" -> "tree_ids".
    danieldk committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    cd6e4fa View commit details
    Browse the repository at this point in the history
  2. Remove unused W400 warning.

    This warning was used when we still allowed the user to specify
    which activations to save.
    danieldk committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    2593dad View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Formatting fixes

    Co-authored-by: Sofie Van Landeghem <svlandeg@users.noreply.github.com>
    danieldk and svlandeg committed Sep 7, 2022
    Configuration menu
    Copy the full SHA
    ac5b1fd View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    b828954 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0bd5730 View commit details
    Browse the repository at this point in the history
  3. Fix EOF spacing

    danieldk committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    8aba93e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a32dd70 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3a16b7b View commit details
    Browse the repository at this point in the history
  6. Revert "spancat: replace a cast by an assertion"

    This reverts commit 0bd5730.
    danieldk committed Sep 8, 2022
    Configuration menu
    Copy the full SHA
    fc78ed4 View commit details
    Browse the repository at this point in the history