Fix Cython build for Python 3.12 (#58)

* Fix Cython build for Python 3.12 While at it: - Add CI tests for Python 3.12. - Remove 3.8 support in preparation of spaCy v4. * GH actions: ignore Metal 2.0 paravirt warning
explosion · Apr 9, 2024 · 63a0b0d · 63a0b0d
1 parent a139a5e
commit 63a0b0d
Show file tree

Hide file tree

Showing 9 changed files with 15 additions and 12 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -21,14 +21,14 @@ jobs:
       fail-fast: false
       matrix:
         os: [ubuntu-latest, windows-latest, macos-latest]
-        python_version: ["3.11"]
+        python_version: ["3.12"]
         include:
-          - os: ubuntu-20.04
-            python_version: "3.8"
           - os: macos-latest
             python_version: "3.9"
           - os: windows-latest
             python_version: "3.10"
+          - os: ubuntu-20.04
+            python_version: "3.11"
     runs-on: ${{ matrix.os }}
 
     steps:
@@ -82,4 +82,4 @@ jobs:
       - name: Run tests
         shell: bash
         run: |
-          python -m pytest --pyargs $MODULE_NAME -Werror
+          python -m pytest --pyargs $MODULE_NAME
diff --git a/build-constraints.txt b/build-constraints.txt
@@ -1,6 +1,4 @@
 # build version constraints for use with wheelwright + multibuild
-numpy==1.17.3; python_version=='3.8' and platform_machine!='aarch64'
-numpy==1.19.2; python_version=='3.8' and platform_machine=='aarch64'
 numpy==1.19.3; python_version=='3.9'
 numpy==1.21.3; python_version=='3.10'
 numpy==1.23.2; python_version=='3.11'

diff --git a/pyproject.toml b/pyproject.toml
@@ -6,3 +6,8 @@ requires = [
     "spacy>=4.0.0.dev1,<4.1.0",
     "numpy",
 ]
+
+[tool.pytest.ini_options]
+filterwarnings = [
+    "ignore:^.*Skipping device Apple Paravirtual device that does not support Metal 2.0.*",
+]
diff --git a/setup.cfg b/setup.cfg
@@ -11,7 +11,7 @@ long_description_content_type = text/markdown
 
 [options]
 zip_safe = false
-python_requires = >=3.8
+python_requires = >=3.9
 install_requires =
     spacy>=4.0.0.dev1,<4.1.0
 

diff --git a/spacy_experimental/biaffine_parser/arc_labeler.pyx b/spacy_experimental/biaffine_parser/arc_labeler.pyx
@@ -1,4 +1,4 @@
-# cython: infer_types=True, profile=True, binding=True
+# cython: infer_types=True, binding=True
 
 from itertools import islice
 import numpy as np

diff --git a/spacy_experimental/biaffine_parser/arc_predicter.pyx b/spacy_experimental/biaffine_parser/arc_predicter.pyx
@@ -1,4 +1,4 @@
-# cython: infer_types=True, profile=True, binding=True
+# cython: infer_types=True, binding=True
 
 from typing import Callable, Dict, Iterable, List, Optional
 from itertools import islice

diff --git a/spacy_experimental/biaffine_parser/mst.pyx b/spacy_experimental/biaffine_parser/mst.pyx
@@ -1,4 +1,4 @@
-# cython: infer_types=True, profile=True, binding=True
+# cython: infer_types=True, binding=True
 
 # Copyright 2018-2020 Daniël de Kok and Tobias Pütz
 # Copyright 2021 ExplosionAI GmbH

diff --git a/spacy_experimental/char_tokenizer/char_ner_tokenizer.pyx b/spacy_experimental/char_tokenizer/char_ner_tokenizer.pyx
@@ -1,4 +1,4 @@
-# cython: infer_types=True, profile=True, binding=True
+# cython: infer_types=True, binding=True
 from typing import Optional, Callable
 
 import srsly

diff --git a/spacy_experimental/char_tokenizer/char_tagger_tokenizer.pyx b/spacy_experimental/char_tokenizer/char_tagger_tokenizer.pyx
@@ -1,4 +1,4 @@
-# cython: infer_types=True, profile=True, binding=True
+# cython: infer_types=True, binding=True
 from typing import Optional, Callable
 
 import srsly