Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with resolving final token in SpanResolver #27

Merged
merged 3 commits into from
Nov 2, 2022

Conversation

polm
Copy link
Contributor

@polm polm commented Oct 24, 2022

The SpanResolver seems unable to include the final token in a Doc in output spans. It will even produce empty spans instead of doing so.

This makes changes so that within the model span end indices are treated as inclusive, and converts them back to exclusive when annotating docs. This has been tested to work, though an automated test should be added.

The SpanResolver seems unable to include the final token in a Doc in
output spans. It will even produce empty spans instead of doing so.

This makes changes so that within the model span end indices are treated
as inclusive, and converts them back to exclusive when annotating docs.
This has been tested to work, though an automated test should be added.
Running the modify tests without the changes from the previous commit,
they fail. This demonstrates and clarifies the bug.
@polm polm marked this pull request as ready for review October 24, 2022 10:07
@polm polm added the bug Something isn't working label Oct 25, 2022
@kadarakos
Copy link
Contributor

When you say tested to work, do you also mean that the results in terms of LEA are sameish as before the change?

@polm
Copy link
Contributor Author

polm commented Oct 31, 2022

Yes, the LEA for the test set is almost identical but slightly higher.

  • fixed: 0.6899794903994366
  • old: 0.687557730072873

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants