Merge branch 'master' into chore/add-type-tests

.github/ISSUE_TEMPLATE/01_bugs.md

@@ -0,0 +1,17 @@
+---
+name: "\U0001F6A8 Submit a Bug Report"
+about: Use this template if you came across a bug or unexpected behaviour differing from the docs.
+---
+
+## How to reproduce the behaviour
+
+<!-- Include a code example or the steps that led to the problem. Please try to be as specific as possible. -->
+
+## Your Environment
+
+<!-- Include details of your environment. -->
+
+- Operating System:
+- Python Version Used:
+- Thinc Version Used:
+- Environment Information:

.github/PULL_REQUEST_TEMPLATE.md

@@ -0,0 +1,23 @@
+<!--- Provide a general summary of your changes in the title. -->
+
+## Description
+
+<!--- Use this section to describe your changes. If your changes required
+testing, include information about the testing environment and the tests you
+ran. If your test fixes a bug reported in an issue, don't forget to include the
+issue number. If your PR is still a work in progress, that's totally fine – just
+include a note to let us know. -->
+
+### Types of change
+
+<!-- What type of change does your PR cover? Is it a bug fix, an enhancement
+or new feature, or a change to the documentation? -->
+
+## Checklist
+
+<!--- Before you submit the PR, go over this checklist and make sure you can
+tick off all the boxes. [] -> [x] -->
+
+- [ ] I confirm that I have the right to submit this contribution under the project's MIT license.
+- [ ] I ran the tests, and all new and existing tests passed.
+- [ ] My changes don't require a change to the documentation, or if they do, I've added all required information.

.github/workflows/autoblack.yml

@@ -12,18 +12,18 @@ jobs:
     if: github.repository_owner == 'explosion'
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v2
+      - uses: actions/checkout@v3
         with:
             ref: ${{ github.head_ref }}
-      - uses: actions/setup-python@v2
-      - run: pip install black
+      - uses: actions/setup-python@v4
+      - run: pip install black -c requirements.txt
       - name: Auto-format code if needed
         run: black thinc
       # We can't run black --check here because that returns a non-zero excit
       # code and makes GitHub think the action failed
       - name: Check for modified files
         id: git-check
-        run: echo ::set-output name=modified::$(if git diff-index --quiet HEAD --; then echo "false"; else echo "true"; fi)
+        run: echo modified=$(if git diff-index --quiet HEAD --; then echo "false"; else echo "true"; fi) >> $GITHUB_OUTPUT
       - name: Create Pull Request
         if: steps.git-check.outputs.modified == 'true'
         uses: peter-evans/create-pull-request@v3

.github/workflows/explosionbot.yml

@@ -8,14 +8,14 @@ on:
 
 jobs:
   explosion-bot:
-    runs-on: ubuntu-18.04
+    runs-on: ubuntu-latest
     steps:
       - name: Dump GitHub context
         env:
           GITHUB_CONTEXT: ${{ toJson(github) }}
         run: echo "$GITHUB_CONTEXT"
-      - uses: actions/checkout@v1
-      - uses: actions/setup-python@v1
+      - uses: actions/checkout@v3
+      - uses: actions/setup-python@v4
       - name: Install and run explosion-bot
         run: |
           pip install git+https://${{ secrets.EXPLOSIONBOT_TOKEN }}@github.com/explosion/explosion-bot
@@ -24,4 +24,4 @@ jobs:
           INPUT_TOKEN: ${{ secrets.EXPLOSIONBOT_TOKEN }}
           INPUT_BK_TOKEN: ${{ secrets.BUILDKITE_SECRET }}
           ENABLED_COMMANDS: "test_gpu,test_slow,test_slow_gpu"
-          ALLOWED_TEAMS: "spacy-maintainers"
+          ALLOWED_TEAMS: "spacy-maintainers"

.github/workflows/tests.yml

@@ -0,0 +1,150 @@
+name: tests
+
+on:
+  push:
+    paths-ignore:
+      - "website/**"
+      - "*.md"
+  pull_request:
+    types: [opened, synchronize, reopened, edited]
+    paths-ignore:
+      - "website/**"
+      - "*.md"
+
+jobs:
+  validate:
+    name: Validate
+    if: github.repository_owner == 'explosion'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Check out repo
+        uses: actions/checkout@v3
+
+      - name: Configure Python version
+        uses: actions/setup-python@v4
+        with:
+          python-version: "3.7"
+          architecture: x64
+
+      - name: black
+        run: |
+          python -m pip install black -c requirements.txt
+          python -m black thinc --check
+      - name: isort
+        run: |
+          python -m pip install isort -c requirements.txt
+          python -m isort thinc --check
+      - name: flake8
+        run: |
+          python -m pip install flake8==5.0.4
+          python -m flake8 thinc --count --select=E901,E999,F821,F822,F823,W605 --show-source --statistics
+  tests:
+    name: Test
+    needs: Validate
+    if: github.repository_owner == 'explosion'
+    strategy:
+      fail-fast: false
+      matrix:
+        os: [ubuntu-latest, windows-latest, macos-latest]
+        python_version: ["3.11"]
+        include:
+          - os: windows-2019
+            python_version: "3.6"
+          - os: macos-latest
+            python_version: "3.7"
+          - os: ubuntu-latest
+            python_version: "3.8"
+          - os: windows-latest
+            python_version: "3.9"
+          - os: macos-latest
+            python_version: "3.10"
+
+    runs-on: ${{ matrix.os }}
+    env:
+      NOTEBOOK_KERNEL: "thinc-notebook-tests"
+
+    steps:
+      - name: Check out repo
+        uses: actions/checkout@v3
+
+      - name: Configure Python version
+        uses: actions/setup-python@v4
+        with:
+          python-version: ${{ matrix.python_version }}
+          architecture: x64
+
+      - name: Install dependencies
+        run: |
+          python -m pip install --upgrade pip setuptools wheel
+          pip install -r requirements.txt
+
+      - name: Build sdist
+        run: |
+          python setup.py build_ext --inplace
+          python setup.py sdist --formats=gztar
+
+      - name: Run mypy
+        run: python -m mypy thinc --no-implicit-reexport
+        if: matrix.python_version != '3.6'
+
+      - name: Delete source directory
+        run: rm -rf thinc
+        shell: bash
+
+      - name: Uninstall all packages
+        run: |
+          python -m pip freeze
+          pip freeze --exclude pywin32 > installed.txt
+          pip uninstall -y -r installed.txt
+
+      - name: Install from sdist
+        run: |
+          SDIST=$(python -c "import os;print(os.listdir('./dist')[-1])" 2>&1)
+          PIP_CONSTRAINT="build-constraints.txt" pip install dist/$SDIST
+        shell: bash
+
+      - name: Test import
+        run: python -c "import thinc"
+
+      - name: Run tests without extras
+        run: |
+          pip install -r requirements.txt
+          pip install ipykernel pydot graphviz
+          python -m ipykernel install --name thinc-notebook-tests --user
+          python -m pytest --pyargs thinc -Werror --cov=thinc --cov-report=term
+
+      # Notes on numpy requirements hacks:
+      # 1. torch does not have a direct numpy requirement but is compiled
+      # against a newer version than the oldest supported numpy for windows and
+      # python 3.10; this version of numpy would not work with
+      # tensorflow~=2.5.0 as specified above, but there is no release for
+      # python 3.10 anyway
+      # 2. restrict to numpy<1.24.0 due to mxnet incompatibility
+      # 3. forbid torch!=1.13.0 due to segfaults with numpy<1.24.0
+      # Note: some of these pip install commands are known to fail for some platforms.
+      # To continue despite errors as in azure pipelines, remove -e from the default
+      # bash flags.
+      - name: Install extras for testing
+        run: |
+          pip install "protobuf~=3.20.0" "tensorflow~=2.5.0"
+          pip install "mxnet; sys_platform != 'win32'"
+          pip install "torch!=1.13.0" --extra-index-url https://download.pytorch.org/whl/cpu
+          pip install "numpy~=1.23.0; python_version=='3.10' and sys_platform=='win32'"
+          pip install "numpy<1.24.0"
+          pip install -r requirements.txt
+          pip uninstall -y mypy
+        shell: bash --noprofile --norc -o pipefail {0}
+
+      - name: Run tests with extras
+        run: python -m pytest --pyargs thinc --cov=thinc --cov-report=term
+
+      - name: Run tests for thinc-apple-ops
+        run: |
+          pip uninstall -y tensorflow
+          pip install thinc-apple-ops
+          python -m pytest --pyargs thinc_apple_ops
+        if: matrix.os == 'macos-latest' && matrix.python_version == '3.10'
+
+      - name: Run tests with thinc-apple-ops
+        run: python -m pytest --pyargs thinc
+        if: matrix.os == 'macos-latest' && matrix.python_version == '3.10'

README.md

@@ -2,7 +2,7 @@
 
 # Thinc: A refreshing functional take on deep learning, compatible with your favorite libraries
 
-### From the makers of [spaCy](https://spacy.io), [Prodigy](https://prodi.gy) and [FastAPI](https://fastapi.tiangolo.com)
+### From the makers of [spaCy](https://spacy.io) and [Prodigy](https://prodi.gy)
 
 [Thinc](https://thinc.ai) is a **lightweight deep learning library** that offers an elegant,
 type-checked, functional-programming API for **composing models**, with support

build-constraints.txt

@@ -5,4 +5,5 @@ numpy==1.17.3; python_version=='3.8' and platform_machine!='aarch64'
 numpy==1.19.2; python_version=='3.8' and platform_machine=='aarch64'
 numpy==1.19.3; python_version=='3.9'
 numpy==1.21.3; python_version=='3.10'
-numpy; python_version>='3.11'
+numpy==1.23.2; python_version=='3.11'
+numpy; python_version>='3.12'