Tests: Correctly handle GPU-resident Tensorflow tensors #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeMe
added
bug
|
@explosion-bot please test_gpu |
URL: https://buildkite.com/explosion-ai/thinc-gpu-test-suite/builds/61 |
danieldk
approved these changes
May 6, 2022
danieldk
reviewed
May 6, 2022
danieldk
pushed a commit
to danieldk/thinc
that referenced
this pull request
May 11, 2022
* Tests: Correctly handle GPU-resident Tensorflow tensors * Simplify `is_supported_backend_array`
danieldk
pushed a commit
to danieldk/thinc
that referenced
this pull request
May 11, 2022
* Tests: Correctly handle GPU-resident Tensorflow tensors * Simplify `is_supported_backend_array`
shadeMe
added a commit
to shadeMe/thinc
that referenced
this pull request
May 11, 2022
* Tests: Correctly handle GPU-resident Tensorflow tensors * Simplify `is_supported_backend_array`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tensorflow automatically allocates on the GPU if possible, which is something the tests below didn't correctly account for. Since the CI host machine's CUDA libraries were not correctly configured, TF silently always used the CPU thereby hiding this bug.