Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix out-of-bounds writes in NumpyOps/CupyOps #664

Merged
merged 3 commits into from
May 17, 2022
Merged

Fix out-of-bounds writes in NumpyOps/CupyOps #664

merged 3 commits into from
May 17, 2022

Commits on May 13, 2022

  1. Fix out-of-bounds writes in NumpyOps/CupyOps 

    - Using `{CupyOps,NumpyOps}.adam` with incompatible shapes for weights,
  gradients, or moments resulted in out-of-bound writes.
- Using `NumpyOps.adam` with non-float32 arrays resulted filling arrays
  with incorrect data.
    @danieldk
    danieldk committed May 13, 2022
    Configuration menu
    Copy the full SHA
    d5b9ec5 View commit details
    Browse the repository at this point in the history

  2. Remove print debugging remnants 

    Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
    @danieldk @adrianeboyd
    danieldk and adrianeboyd committed May 13, 2022
    Configuration menu
    Copy the full SHA
    6f8c7e4 View commit details
    Browse the repository at this point in the history

  3. More print debugging remnants 

    Co-authored-by: Adriane Boyd <adrianeboyd@gmail.com>
    @danieldk @adrianeboyd
    danieldk and adrianeboyd committed May 13, 2022
    Configuration menu
    Copy the full SHA
    f32a70c View commit details
    Browse the repository at this point in the history