-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WEB-10 Update Gatsby #827
Merged
Merged
WEB-10 Update Gatsby #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essenmitsosse
force-pushed
the
update-gatsby
branch
from
December 21, 2022 13:28
c29e4c5
to
d8cb2b0
Compare
essenmitsosse
force-pushed
the
update-gatsby
branch
4 times, most recently
from
December 21, 2022 14:32
8c2c9aa
to
1ccd914
Compare
`gatsby-plugin-sass` automatically uses `dart-sass` unless `node-sass` is not installed. Since `node-sass` doesn't support ARM chips yet this switch should fix problem for M1 users.
This was breaking the layout of the Markdown that followed
essenmitsosse
force-pushed
the
update-gatsby
branch
from
December 21, 2022 15:11
1ccd914
to
8fedfae
Compare
This is the best explanation I could finde regarding the chunk order warnings, that where flooding the console: https://stackoverflow.com/questions/51971857/mini-css-extract-plugin-warning-in-chunk-chunkname-mini-css-extract-plugin-con?answertab=trending#tab-top After trying out all the suggestions — non of which worked — I figured, since there wasn't a problem to begin with anyway, I might as well go with the "kill it" way of fixing, by telling `webpack`/`MiniCssExtractPlugin` to ignore the order.
Assign arrow function to a variable before exporting as module default
essenmitsosse
force-pushed
the
update-gatsby
branch
from
December 21, 2022 15:27
5153906
to
27b767b
Compare
svlandeg
approved these changes
Dec 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into this, Marcus! Is this PR good to merge or was there anything else you wanted to add/do/test?
I have some minor fixes but they are not necessary to get the site running and this PR is good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the barebone changes necessary to get the site to build on Netlify.
Deploy Preview