Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WEB-10 Update Gatsby #827

Merged
merged 12 commits into from
Dec 22, 2022
Merged

WEB-10 Update Gatsby #827

merged 12 commits into from
Dec 22, 2022

Conversation

essenmitsosse
Copy link
Contributor

@essenmitsosse essenmitsosse commented Dec 21, 2022

These are the barebone changes necessary to get the site to build on Netlify.

Deploy Preview

@essenmitsosse essenmitsosse marked this pull request as ready for review December 21, 2022 12:22
@essenmitsosse essenmitsosse marked this pull request as draft December 21, 2022 12:32
@essenmitsosse essenmitsosse marked this pull request as ready for review December 21, 2022 12:59
@essenmitsosse essenmitsosse force-pushed the update-gatsby branch 4 times, most recently from 8c2c9aa to 1ccd914 Compare December 21, 2022 14:32
`gatsby-plugin-sass` automatically uses `dart-sass` unless `node-sass` is not installed. Since `node-sass` doesn't support ARM chips yet this switch should fix problem for M1 users.
This was breaking the layout of the Markdown that followed
This is the best explanation I could finde regarding the chunk order warnings, that where flooding the console: https://stackoverflow.com/questions/51971857/mini-css-extract-plugin-warning-in-chunk-chunkname-mini-css-extract-plugin-con?answertab=trending#tab-top

After trying out all the suggestions — non of which worked — I figured, since there wasn't a problem to begin with anyway, I might as well go with the "kill it" way of fixing, by telling `webpack`/`MiniCssExtractPlugin` to ignore the order.
Assign arrow function to a variable before exporting as module default
Copy link
Member

@svlandeg svlandeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this, Marcus! Is this PR good to merge or was there anything else you wanted to add/do/test?

@essenmitsosse
Copy link
Contributor Author

I have some minor fixes but they are not necessary to get the site running and this PR is good to go.

@svlandeg svlandeg merged commit 17fbcf4 into explosion:master Dec 22, 2022
@essenmitsosse essenmitsosse deleted the update-gatsby branch December 23, 2022 00:59
@essenmitsosse essenmitsosse changed the title Update Gatsby WEB-10 Update Gatsby Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants