Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix brittleness during builds #843

Merged

Conversation

essenmitsosse
Copy link
Contributor

Description

91f4667 introduced a hacky solution, that unfortunatly caused the build/dev server to fail, when /website/src/fonts doesn't exist. This removes the coupling of fonts.sass to other features while keeping it optional.

Types of change

  • Bug fix for local build/dev server

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

91f4667 introduced a hacky solution, that unfortunatly caused the build/dev server to fail, when `/website/src/fonts` doesn't exist. This removes the coupling of `fonts.sass` to other features while keeping it optional.
@ines ines merged commit 2ef308c into explosion:master Jan 18, 2023
@svlandeg svlandeg added the bug Bugs and behaviour differing from documentation label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bugs and behaviour differing from documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants