-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Import mxnet and tensorflow only if explicitly enabled #890
Import mxnet and tensorflow only if explicitly enabled #890
Conversation
This was the most minimal way I could think of to do this for thinc v8. I mainly think that nearly no one is using thinc with mxnet or tensorflow so this isn't going to be very breaking either way. I don't know how/if you could add deprecation warnings to v8.1 to prepare users for the change. Again, I think it's hardly anyone. I doubt many people are using this ancient version of tensorflow and I guess I don't really know, but I don't think mxnet ever had a large user base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably decide if we want to remove this functionality from Thinc 9 and if so, add warnings to the enable_
functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Maybe @danieldk wants to give it a final once-over?
Description
Import
mxnet
andtensorflow
only if explicitly enabledTypes of change
?
Checklist