Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import mxnet and tensorflow only if explicitly enabled #890

Conversation

adrianeboyd
Copy link
Contributor

Description

Import mxnet and tensorflow only if explicitly enabled

Types of change

?

Checklist

  • I confirm that I have the right to submit this contribution under the project's MIT license.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added the feat / shims Shims for PyTorch, TensorFlow etc. label Jul 26, 2023
@adrianeboyd
Copy link
Contributor Author

adrianeboyd commented Jul 26, 2023

This was the most minimal way I could think of to do this for thinc v8.

I mainly think that nearly no one is using thinc with mxnet or tensorflow so this isn't going to be very breaking either way.

I don't know how/if you could add deprecation warnings to v8.1 to prepare users for the change. Again, I think it's hardly anyone. I doubt many people are using this ancient version of tensorflow and I guess I don't really know, but I don't think mxnet ever had a large user base.

@adrianeboyd adrianeboyd reopened this Jul 27, 2023
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably decide if we want to remove this functionality from Thinc 9 and if so, add warnings to the enable_ functions.

@adrianeboyd adrianeboyd linked an issue Aug 7, 2023 that may be closed by this pull request
Copy link
Contributor

@rmitsch rmitsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe @danieldk wants to give it a final once-over?

@danieldk danieldk merged commit 4db3879 into explosion:develop Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat / shims Shims for PyTorch, TensorFlow etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tensorflow dependency slows spacy down
3 participants