Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: allow multiple entrypoints for different sub-actions #121

Merged
merged 6 commits into from
Nov 16, 2021

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Nov 16, 2021

Linked issue

This changes the current setup to allow for multiple sub-actions, just like CodeQL. It's backward compatible by using the src/actions/setup.ts as the default action from the root.

With this, we can create sub-actions like:

  • Publish with Expo CLI
  • Build with EAS CLI
  • Comment QR code in the PR for a specific release channel

Additional context

I also applied some other changes:

  • Upgrade NCC to latest version
  • Minify the output
  • Enable sourcemaps

@byCedric byCedric force-pushed the refactor/multiple-actions branch 2 times, most recently from 4238505 to c695313 Compare November 16, 2021 12:47
@byCedric byCedric force-pushed the refactor/multiple-actions branch from c695313 to 75cf0c8 Compare November 16, 2021 13:38
@byCedric byCedric merged commit 8a7306a into expo:main Nov 16, 2021
@byCedric byCedric deleted the refactor/multiple-actions branch November 24, 2021 14:42
github-actions bot pushed a commit that referenced this pull request Jan 13, 2022
## [7.0.0](6.0.0...7.0.0) (2022-01-13)

### ⚠ BREAKING CHANGES

* some input options are deprecated
  - Username and password authentication is dropped in favor of tokens
  - Custom cache keys are dropped
  - Custom install error handler is dropped

### Bug fixes

* use which instead of npx to authenticate ([#147](#147)) ([c5d2c0f](c5d2c0f))

### Code changes

* allow multiple entrypoints for different sub-actions ([#121](#121)) ([8a7306a](8a7306a))
* clean up setup action ([#146](#146)) ([439ff4c](439ff4c))
* enable caches by default ([#148](#148)) ([72d4067](72d4067))
* replace libnpm with npm cli ([#139](#139)) ([4f28493](4f28493))
* roll back to ncc because of swc bundling issues ([#144](#144)) ([3007741](3007741))
* update the outdated workflows and use node 16 ([#138](#138)) ([3134e26](3134e26))
* upgrade to node 16 github actions runtime ([#137](#137)) ([3bf9181](3bf9181))
* use boolean input instead of manual conversion ([#127](#127)) ([f1fe877](f1fe877))
* use spaces for indentation ([#126](#126)) ([ff2ff0f](ff2ff0f))
* use swc pack instead of ncc ([#140](#140)) ([3f9e947](3f9e947))

### Other chores

* add basic e2e test workflow for main action ([#141](#141)) ([414c169](414c169))
* add manual trigger to the tests ([4908a48](4908a48))
* always use lf for build files ([#122](#122)) ([a9b9cfe](a9b9cfe))
* bump semver-regex from 3.1.2 to 3.1.3 ([#114](#114)) ([50c0ef9](50c0ef9))
* bump tar from 4.4.13 to 4.4.19 ([#112](#112)) ([5f5673b](5f5673b))
* bump tmpl from 1.0.4 to 1.0.5 ([#115](#115)) ([92ec93f](92ec93f))
* clean up dependencies and eslint rules ([#145](#145)) ([3ae7999](3ae7999))
* clean up master references in release and workflows ([#104](#104)) ([a2d9b1c](a2d9b1c))
* clean up tsconfig and eslint rules ([#123](#123)) ([c20146f](c20146f))
* lint root files with prettier and eslint ([#125](#125)) ([1cfa7bb](1cfa7bb))
* rebuild project ([45b79a0](45b79a0))
* rebuild project after dependency bumps ([b099f17](b099f17))
* remove husky and improve ci build message ([#128](#128)) ([39b0d36](39b0d36))
* simplify review and update build detection ([#142](#142)) ([ee415b0](ee415b0))
* update `setup-node` action to `v2` release ([#119](#119)) ([3b3e6b8](3b3e6b8))
* update the action manifest ([633cdf0](633cdf0))
* upgrade dev dependencies and rebuild action ([#120](#120)) ([186ef00](186ef00))

### Documentation changes

* fix broken sup element in readme ([0b1822a](0b1822a))
* fix github capitalization ([#116](#116)) ([b602469](b602469))
* fix unsplash comment on pr branch reference ([#110](#110)) ([f14253e](f14253e))
* update expo.io links to expo.dev ([#111](#111)) ([1c8e5a2](1c8e5a2))
* update node version reference in readme ([#107](#107)) ([3ba667b](3ba667b))
* update readme and contributing guides ([521de72](521de72))
* use `main` branch to update `v{major}` tag ([#103](#103)) ([def44e2](def44e2))
github-actions bot pushed a commit that referenced this pull request Jan 15, 2022
## [7.0.0](6.0.0...7.0.0) (2022-01-15)

### ⚠ BREAKING CHANGES

* some input options are deprecated
  - Username and password authentication is dropped in favor of tokens
  - Custom cache keys are dropped
  - Custom install error handler is dropped

### New features

* add comment qr code subaction ([#149](#149)) ([4648212](4648212))

### Bug fixes

* use which instead of npx to authenticate ([#147](#147)) ([c5d2c0f](c5d2c0f))

### Code changes

* allow multiple entrypoints for different sub-actions ([#121](#121)) ([8a7306a](8a7306a))
* clean up setup action ([#146](#146)) ([439ff4c](439ff4c))
* enable caches by default ([#148](#148)) ([72d4067](72d4067))
* replace libnpm with npm cli ([#139](#139)) ([4f28493](4f28493))
* roll back to ncc because of swc bundling issues ([#144](#144)) ([3007741](3007741))
* update the outdated workflows and use node 16 ([#138](#138)) ([3134e26](3134e26))
* upgrade to node 16 github actions runtime ([#137](#137)) ([3bf9181](3bf9181))
* use assert instead of if statements ([#150](#150)) ([e4ef6e6](e4ef6e6))
* use boolean input instead of manual conversion ([#127](#127)) ([f1fe877](f1fe877))
* use spaces for indentation ([#126](#126)) ([ff2ff0f](ff2ff0f))
* use swc pack instead of ncc ([#140](#140)) ([3f9e947](3f9e947))

### Other chores

* add basic e2e test workflow for main action ([#141](#141)) ([414c169](414c169))
* add manual trigger to the tests ([4908a48](4908a48))
* always use lf for build files ([#122](#122)) ([a9b9cfe](a9b9cfe))
* bump semver-regex from 3.1.2 to 3.1.3 ([#114](#114)) ([50c0ef9](50c0ef9))
* bump tar from 4.4.13 to 4.4.19 ([#112](#112)) ([5f5673b](5f5673b))
* bump tmpl from 1.0.4 to 1.0.5 ([#115](#115)) ([92ec93f](92ec93f))
* clean up dependencies and eslint rules ([#145](#145)) ([3ae7999](3ae7999))
* clean up master references in release and workflows ([#104](#104)) ([a2d9b1c](a2d9b1c))
* clean up tsconfig and eslint rules ([#123](#123)) ([c20146f](c20146f))
* lint root files with prettier and eslint ([#125](#125)) ([1cfa7bb](1cfa7bb))
* rebuild project ([45b79a0](45b79a0))
* rebuild project after dependency bumps ([b099f17](b099f17))
* remove husky and improve ci build message ([#128](#128)) ([39b0d36](39b0d36))
* simplify review and update build detection ([#142](#142)) ([ee415b0](ee415b0))
* update `setup-node` action to `v2` release ([#119](#119)) ([3b3e6b8](3b3e6b8))
* update semantic release to update the build ([354dc08](354dc08))
* update the action manifest ([633cdf0](633cdf0))
* upgrade dev dependencies and rebuild action ([#120](#120)) ([186ef00](186ef00))

### Documentation changes

* fix broken sup element in readme ([0b1822a](0b1822a))
* fix github capitalization ([#116](#116)) ([b602469](b602469))
* fix unsplash comment on pr branch reference ([#110](#110)) ([f14253e](f14253e))
* update default values in readme ([c2f11d2](c2f11d2))
* update expo.io links to expo.dev ([#111](#111)) ([1c8e5a2](1c8e5a2))
* update node version reference in readme ([#107](#107)) ([3ba667b](3ba667b))
* update readme and contributing guides ([521de72](521de72))
* use `main` branch to update `v{major}` tag ([#103](#103)) ([def44e2](def44e2))
@github-actions
Copy link

🎉 This PR is included in version 7.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this pull request Jan 17, 2022
## [7.0.0](6.0.0...7.0.0) (2022-01-17)

### ⚠ BREAKING CHANGES

* some input options are deprecated
  - Username and password authentication is dropped in favor of tokens
  - Custom cache keys are dropped
  - Custom install error handler is dropped

### New features

* add comment qr code subaction ([#149](#149)) ([4648212](4648212))

### Bug fixes

* remove double resolving package versions ([#152](#152)) ([d53d38f](d53d38f))
* use which instead of npx to authenticate ([#147](#147)) ([c5d2c0f](c5d2c0f))

### Code changes

* allow multiple entrypoints for different sub-actions ([#121](#121)) ([8a7306a](8a7306a))
* clean up setup action ([#146](#146)) ([439ff4c](439ff4c))
* enable caches by default ([#148](#148)) ([72d4067](72d4067))
* replace libnpm with npm cli ([#139](#139)) ([4f28493](4f28493))
* roll back to ncc because of swc bundling issues ([#144](#144)) ([3007741](3007741))
* update the outdated workflows and use node 16 ([#138](#138)) ([3134e26](3134e26))
* upgrade to node 16 github actions runtime ([#137](#137)) ([3bf9181](3bf9181))
* use assert instead of if statements ([#150](#150)) ([e4ef6e6](e4ef6e6))
* use boolean input instead of manual conversion ([#127](#127)) ([f1fe877](f1fe877))
* use spaces for indentation ([#126](#126)) ([ff2ff0f](ff2ff0f))
* use swc pack instead of ncc ([#140](#140)) ([3f9e947](3f9e947))

### Other chores

* add basic e2e test workflow for main action ([#141](#141)) ([414c169](414c169))
* add manual trigger to the tests ([4908a48](4908a48))
* always use lf for build files ([#122](#122)) ([a9b9cfe](a9b9cfe))
* bump semver-regex from 3.1.2 to 3.1.3 ([#114](#114)) ([50c0ef9](50c0ef9))
* bump tar from 4.4.13 to 4.4.19 ([#112](#112)) ([5f5673b](5f5673b))
* bump tmpl from 1.0.4 to 1.0.5 ([#115](#115)) ([92ec93f](92ec93f))
* clean up dependencies and eslint rules ([#145](#145)) ([3ae7999](3ae7999))
* clean up master references in release and workflows ([#104](#104)) ([a2d9b1c](a2d9b1c))
* clean up tsconfig and eslint rules ([#123](#123)) ([c20146f](c20146f))
* create new release 7.0.0 ([d50f5dd](d50f5dd)), closes [#149](#149) [#147](#147) [#121](#121) [#146](#146) [#148](#148) [#139](#139) [#144](#144) [#138](#138) [#137](#137) [#150](#150) [#127](#127) [#126](#126) [#140](#140) [#141](#141) [#122](#122) [#114](#114) [#112](#112) [#115](#115) [#145](#145) [#104](#104) [#123](#123) [#125](#125) [#128](#128) [#142](#142) [#119](#119) [#120](#120) [#116](#116) [#110](#110) [#111](#111) [#107](#107) [#103](#103)
* lint root files with prettier and eslint ([#125](#125)) ([1cfa7bb](1cfa7bb))
* rebuild project ([45b79a0](45b79a0))
* rebuild project after dependency bumps ([b099f17](b099f17))
* remove husky and improve ci build message ([#128](#128)) ([39b0d36](39b0d36))
* run test workflow every day at 15:00 utc ([fd33d59](fd33d59))
* simplify review and update build detection ([#142](#142)) ([ee415b0](ee415b0))
* update `setup-node` action to `v2` release ([#119](#119)) ([3b3e6b8](3b3e6b8))
* update semantic release to update the build ([354dc08](354dc08))
* update the action manifest ([633cdf0](633cdf0))
* upgrade dev dependencies and rebuild action ([#120](#120)) ([186ef00](186ef00))

### Documentation changes

* explicitly add non interactive flag ([#151](#151)) ([844ea09](844ea09))
* fix broken sup element in readme ([0b1822a](0b1822a))
* fix github capitalization ([#116](#116)) ([b602469](b602469))
* fix unsplash comment on pr branch reference ([#110](#110)) ([f14253e](f14253e))
* update comment preview readme header ([7a46a49](7a46a49))
* update default values in readme ([c2f11d2](c2f11d2))
* update expo.io links to expo.dev ([#111](#111)) ([1c8e5a2](1c8e5a2))
* update node version reference in readme ([#107](#107)) ([3ba667b](3ba667b))
* update readme and contributing guides ([521de72](521de72))
* update step title in example with eas cli ([7934883](7934883))
* update workflow badge with test status ([99593b8](99593b8))
* use `main` branch to update `v{major}` tag ([#103](#103)) ([def44e2](def44e2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant