-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature(preview): add qr-target
and use proper QR codes for expo-go
and dev-build
#247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of `expo-go`
byCedric
changed the title
fix(preview): use app slug to generate proper EAS Update preview
feature(preview)!: add Nov 28, 2023
qr-target
and use proper QR codes for Expo Go and Dev Client projects
byCedric
force-pushed
the
@bycedric/preview/fix-qr-codes
branch
from
December 2, 2023 13:51
85ebe6d
to
d4168c8
Compare
byCedric
changed the title
feature(preview)!: add
feature(preview)!: add Dec 2, 2023
qr-target
and use proper QR codes for Expo Go and Dev Client projectsqr-target
and use proper QR codes for expo-go
and dev-build
byCedric
force-pushed
the
@bycedric/preview/fix-qr-codes
branch
2 times, most recently
from
December 2, 2023 13:58
fcf007a
to
bda94c4
Compare
byCedric
force-pushed
the
@bycedric/preview/fix-qr-codes
branch
from
December 2, 2023 14:00
bda94c4
to
307c27c
Compare
byCedric
changed the title
feature(preview)!: add
feature(preview): add Dec 2, 2023
qr-target
and use proper QR codes for expo-go
and dev-build
qr-target
and use proper QR codes for expo-go
and dev-build
expo-bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
## [8.2.0](8.1.0...8.2.0) (2023-12-02) ### New features * **preview:** add `qr-target` and use proper QR codes for `expo-go` and `dev-build` ([#247](#247)) ([54efbfd](54efbfd)) ### Documentation changes * **preview:** clarify the branch and workflow trigger relations ([#246](#246)) ([ccfad6f](ccfad6f))
🎉 This PR is included in version 8.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the QR codes for both Expo Go and Dev Client projects.
expo-dev-client
is currently used in the project, and if so, it uses theexp+<slug>://
QR code prefix.You can override this logic by setting the
qr-target: expo-go | dev-build
.Troubleshouting
If you run into issues with
expo-dev-client
QR codes, follow these steps.expo-dev-client
plugin is added to the app.json plugins list.expo-dev-client
build can be opened through anexp+<slug>://
deep link. (see QR codes broken when using custom schemes #240)Linked issue
See #240