Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[screen-orientation] addOrientationChangeListener not working for iPadOS #23387

Closed
sbkl opened this issue Jul 8, 2023 · 1 comment · Fixed by #23656
Closed

[screen-orientation] addOrientationChangeListener not working for iPadOS #23387

sbkl opened this issue Jul 8, 2023 · 1 comment · Fixed by #23656
Assignees

Comments

@sbkl
Copy link

sbkl commented Jul 8, 2023

Minimal reproducible example

https://gist.github.com/sbkl/a9efcdca96ce0aa289814ff44fb8fc79

Summary

addOrientationChangeListener not working for iPadOS. Working fine for iOS.

In the app.config.ts, I removed the orientation key and setup the plugin according to the documentation and set the screen orientation to "DEFAULT" which is supposed to make the screen unlocked by default but it is not the case so when initialising the app, I have to call the unlockAsync function to make the screen unlocked.

Expo SDK 49
IpadOS and iOS versions: 16.4
Build made EAS build
expo-screen-orientation: 6.0.2

app.config.js

  plugins: [   
    [
      "expo-screen-orientation",
      {
        initialOrientation: "DEFAULT",
      },
    ],
  ],

Expected Behaviour:
currentOrientation state should update and be consoled log each time the device changes orientation. Works fine on iOS but not in iPadOS.

Environment

System:
  OS: macOS 13.4.1
  Shell: 5.9 - /bin/zsh
Binaries:
  Node: 18.13.0 - /usr/local/bin/node
  Yarn: 1.22.17 - /usr/local/bin/yarn
  npm: 8.19.3 - /usr/local/bin/npm
Managers:
  CocoaPods: 1.11.2 - /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
IDEs:
  Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
npmGlobalPackages:
  eas-cli: 3.15.0
Expo Workflow: bare
@sbkl sbkl added the needs validation Issue needs to be validated label Jul 8, 2023
@expo-bot expo-bot added needs review Issue is ready to be reviewed by a maintainer and removed needs validation Issue needs to be validated labels Jul 8, 2023
@expo-bot
Copy link
Collaborator

expo-bot commented Jul 8, 2023

Thank you for filing this issue!
This comment acknowledges we believe this may be a bug and there’s enough information to investigate it.
However, we can’t promise any sort of timeline for resolution. We prioritize issues based on severity, breadth of impact, and alignment with our roadmap. If you’d like to help move it more quickly, you can continue to investigate it more deeply and/or you can open a pull request that fixes the cause.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants