-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
source maps not uploading #364
Comments
Same here, it's probably because the bundles are no longer |
@mikevercoelen assume you're talking about this change expo/expo#22098? I've asked in that thread for some more details on the filename change. |
Same issue |
Expo hasn't replied to me after multiple attempts to post in their Discord, sadly. We also have the issue with sourcemaps ever since we've moved our web export over to use the metro bundler. I've created an issue on the Sentry React Native Github: getsentry/sentry-react-native#3244 |
Same issue, same environment. |
I'm seeing the same issue here for iOS with SDK 49.0.7, Sentry React-Native 5.5.0 and sentry-expo 7.0.0. Also using a managed build through EAS. Android seems to work fine though, so for me at least it's just an iOS issue. |
We're only building for iOS, so that's a helpful data point that it works for Android @robutler - thanks. |
Here's an except of the "Xcode Logs" section of our EAS builds in case it could be helpful to anyone:
The presence of both |
Same issue here.... I've been playing around a bit with the Cli command: The source maps gets uploaded but seems like the uploaded artifact is unable to be linked with the uploaded binary/release in Sentry... Would be great if we could get a reply from the author soon 😞 |
Same issue, same environment. |
share my investigation in getsentry/sentry-react-native#3244 (comment) and see if sentry-cli can have a way to add the support. |
Same issue happening on iOS |
I've been running into this too. While trying to see what was going on during the eas builds, I also noticed using SENTRY_LOG_LEVEL=debug is a bit more verbose on Android builds while on iOS builds its radio silent (no indication of failing or even uploading anything). |
Thank you @Kudo for sharing details in getsentry/sentry-react-native#3244. The issue is closed as it was not related to the Expo SDK 49 bundle command changes. Sentry will update |
|
@krystofwoldrich Awesome thanks! Does this incoming PR also include a fix for pushing |
@mikevercoelen No, it doesn't fix #335. |
Updating to Thanks so much for helping to resolve this @Kudo & @krystofwoldrich - very appreciative 🙏 |
@josh- Are you using sentry-expo's plugin for the source map upload in eas? |
@sperrys yep - we're using the |
Unsure if this is also related to Expo v49 but seems that our Sentry exceptions aren't being aren't being correctly symbolicated with our newly-uploaded source maps. I see the original minified stack trace in Sentry, and when running the following command
Will do some further digging but interested to know whether anyone else is encountering this also once their source maps are being successfully uploaded? |
@josh- Thanks for the message, have you figured it out? If you are still having trouble, you can open an issue in |
@krystofwoldrich realised that some errors weren't being symbolicated because they have a |
That was my conclusion as well, but how to get it working now?? |
We stopped seeing symbolicated stack traces in Sentry after upgrading to Expo SDK 49 (we're also building on EAS). Today I updated our react native project to use @sentry/cli@2.20.7 and now I'm seeing source maps uploaded to Sentry again, but we're still not seeing new crashes with a stack trace as expected. One difference I've noticed is that Source Maps are showing up under the Artifact Bundles tab instead of Source Maps tab like they were before (I'm not sure what that means). |
We have the same.. But we're just happy we have stack-traces on builds again. But now we need to figure out how we can manually upload source maps when we decide to push OTA updates. Any of you guys got some ideas on how to achieve this with the new |
@josh- @Kudo @krystofwoldrich how do I incorporate this fix? I'm also on Expo SDK 49 and have followed the guide to set up sentry-expo correctly. However I see sentry-expo@v7.0.1 still uses @sentry/react-native(v5.5) which uses an older version of @sentry/cli which still doesn't upload the source maps correctly. Do you guys mind sharing your package.json and/or eas build configuration which allows for them to get uploaded successfully? Thank you 🙏 |
@ssrballin You can override the version by adding this to your package.json. I have mine working for now with this. You should remove this once the @sentry/cli version is officially updated.
|
@Kungpowpow Thanks for the suggestion 🙏 I did try this out and unfortunately didn't work either :/ Errors are getting reported but there is no stack trace, I think source maps aren't uploading correctly like they used to (I would see a new release and 2 artifacts if they did upload successfully in the past)
Also:
|
I was able to resolve by removing my Everything is working now, thank you @Kungpowpow and everyone! 🥳 |
currently latest if there's still symbolicated stack trace problem and having an easier repro, let me know what we could help. |
It seems that now |
bump. Anyone figured out how to upload source-maps on EAS Update, and not only on build yet? |
I cannot even get sourcemaps for EAS builds :/ Is there a way to see that / which sourcemaps are uploaded? |
@sem4phor you can view uploaded source maps by going to project settings in Sentry and clicking "Source Maps" under "Processing". |
@josh- and is there a way to track in the EAS build if the hook is executed to upload them? I followed all instructions installed the plugin etc. but no sourcemaps are getting uploaded :/ |
@sem4phor for iOS, open the logs in the "Xcode Logs" section of an EAS build: And and you should notice log lines like:
and then further down:
|
After building for "preview" I get some logs regarding sourcemaps on ios (whereas on the simulator build I did not get anything related to them):
then further down:
And in the end no release or sourcemaps are added to sentry. I followed every step in the docs :( and I use the latest package versions of expo / rn etc. |
@krystofwoldrich unfortunaltyl updating manually breaks my build |
For OTA , we had luck getting it to work by renaming the .hbc files to index.android.bundle for android and to main.jsbundle for ios and uploading those along with the .map files. |
I created this bash script that renames the files for me and uploads them to Sentry.
|
The script I shared above can be invoked as a side effect of the OTA update, getting all the arguments automatically. This is a snippet from a different bash script I use Note: Here I'm hard-coding the channel to be "production-beta" because this particular script is for pushing OTAs for the beta channel. I have a different script for pushing to production.
|
this works for me
|
Hello everyone, EAS Updates source maps upload is now as easy as Update to https://github.com/getsentry/sentry-react-native/releases/tag/5.16.0 or newer to get all the new features. Migration guides available: |
Hello! I've been scratching my head: does this package exist? I tried accessing it on npmjs.com and didn't see it on there either. Just want to confirm I'm not doing something silly. Thank you!
|
@peterpme I believe you need to run This is because recent versions of |
according to expo50 changelog (https://expo.dev/changelog/2023/12-12-sdk-50-beta)
|
Summary
Source maps haven't been appearing in sentry since upgrading to Expo SDK v49 + sentry-expo v7. No errors are being thrown, just no Source Maps -> Artifact Bundles since July 7. We use EAS for builds.
Managed or bare workflow? If you have
ios/
orandroid/
directories in your project, the answer is bare!managed
What platform(s) does this occur on?
iOS
SDK Version (managed workflow only)
49.0.6
Environment
System:
OS: macOS 13.4.1
Shell: 5.9 - /bin/zsh
Binaries:
Node: 18.17.0 - /private/var/folders/7k/6cjxfzn55jx59ng8l7vbkh780000gn/T/xfs-58192736/node
Yarn: 3.6.1 - /private/var/folders/7k/6cjxfzn55jx59ng8l7vbkh780000gn/T/xfs-58192736/yarn
npm: 9.6.7 - /opt/homebrew/opt/node@18/bin/npm
Watchman: 2023.08.07.00 - /opt/homebrew/bin/watchman
Managers:
CocoaPods: 1.12.1 - /opt/homebrew/bin/pod
SDKs:
iOS SDK:
Platforms: DriverKit 22.4, iOS 16.4, macOS 13.3, tvOS 16.4, watchOS 9.4
IDEs:
Android Studio: 2021.2 AI-212.5712.43.2112.8815526
Xcode: 14.3.1/14E300c - /usr/bin/xcodebuild
npmGlobalPackages:
eas-cli: 4.0.0
expo-cli: 6.3.8
Expo Workflow: managed
Reproducible demo or steps to reproduce from a blank project
Not sure how to come up with a demo or how to debug this issue. With some guidance, I'd be happy to take some steps.
The text was updated successfully, but these errors were encountered: