Update transpilation to remove import/export syntax from base package #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/expoio/vector-icons/am6rgMr9uB6jAP4oXoixApc6Cd3Q |
This was referenced Sep 19, 2021
brentvatne
approved these changes
Sep 22, 2021
|
my only concern about this is that, unless i'm mistaken, there is a minor breaking change -- if someone was, for some reason, using cjs to import a font directly we won't have // This won't work anymore
const AntDesign = require('@expo/vector-icons/AntDesign').default; |
|
@EvanBacon Do we still need this refactor? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JS engines that we use with React Native do not support import/export syntax so we essentially offload the changes in this PR to be performed locally on every user's machine. This doesn't fully fix the package since the vendor still has es modules.