Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use node lookup method instead of custom code #134

Merged
merged 1 commit into from
Sep 3, 2022

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented Sep 3, 2022

Linked issue

We don't need to iterate over every node, we can just ask jsonc to find nodes at expo.plugins or something like that.

@byCedric byCedric merged commit 866d5c7 into main Sep 3, 2022
@byCedric byCedric deleted the refactor/remove-custom-jsonc-node-lookup branch September 3, 2022 21:25
github-actions bot pushed a commit that referenced this pull request Oct 13, 2022
## [0.9.1](0.9.0...0.9.1) (2022-10-13)

### Bug fixes

* set `null` as default for exclude glob patterns ([#138](#138)) ([5403474](5403474))
* set language for app manifests and eas to jsonc ([#137](#137)) ([665983b](665983b))

### Code changes

* use node lookup method instead of custom code ([#134](#134)) ([866d5c7](866d5c7))
@github-actions
Copy link

🎉 This PR is included in version 0.9.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant