fix: add workspace.fs.stat error handling when files are missing
#259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
pushed a commit
that referenced
this pull request
Mar 13, 2024
## [1.5.0](1.4.3...1.5.0) (2024-03-13) ### New features * add more infers to determine device platform when debugging ([#260](#260)) ([d89a982](d89a982)) ### Bug fixes * add `workspace.fs.stat` error handling when files are missing ([#259](#259)) ([a5c6199](a5c6199)) * use optional chaining when validating relative paths in manifest asset completions ([#258](#258)) ([ee37364](ee37364))
|
🎉 This PR is included in version 1.5.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked issue
It is being reported as unhandled promise exception, which should never happen. This PR makes the
workspace.fs.stata safe operation by wrapping it in try catch, and aborting where necessary.