Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add webpack ignore patch to dynamic config plugins import #33

Merged
merged 4 commits into from
May 10, 2021
Merged

fix: add webpack ignore patch to dynamic config plugins import #33

merged 4 commits into from
May 10, 2021

Conversation

byCedric
Copy link
Member

@byCedric byCedric commented May 8, 2021 •
edited
Loading

Linked issue

This disables the @expo/config-plugins require modification by webpack.

Additional context

Also added an extra launch script that runs the extension locally in production mode.

@byCedric byCedric requested a review from EvanBacon May 8, 2021 19:17
EvanBacon
EvanBacon approved these changes May 8, 2021
View reviewed changes
Copy link
Contributor

@EvanBacon EvanBacon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appears to work locally in production

@byCedric byCedric merged commit dae77c0 into main May 10, 2021
@byCedric byCedric deleted the fix/webpack-require-config-plugins branch May 10, 2021 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBacon EvanBacon EvanBacon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byCedric @EvanBacon