Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort mod result keys #52

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Conversation

EvanBacon
Copy link
Contributor

Sometimes the results change order but don't actually change, this PR aims to fix that by sorting the keys of the object (JS anti-pattern).

@byCedric byCedric changed the title Sort result keys fix: sort mod result keys Jun 9, 2021
@byCedric byCedric merged commit 3a5fd07 into main Jun 9, 2021
@byCedric byCedric deleted the @evanbacon/preview/sort-result-keys branch June 9, 2021 11:40
github-actions bot pushed a commit that referenced this pull request Jun 9, 2021
## [0.6.0](0.5.0...0.6.0) (2021-06-09)

### New features

* apply diff styling to modified preview lines ([#49](#49)) ([199dafe](199dafe))

### Bug fixes

* app name change breaking ios previews ([#51](#51)) ([260883f](260883f))
* broken commit links in changelog ([f148d13](f148d13))
* clean up the clear modules file ([fd52236](fd52236))
* disable helpers on preview files ([#50](#50)) ([2aad139](2aad139))
* sort mod result keys ([#52](#52)) ([3a5fd07](3a5fd07))

### Other chores

* be more strict with linting in ci ([0d0da51](0d0da51))
* reduce the lint annotations in pull requests ([4b15ef3](4b15ef3))
* remove skip ci from release commit ([d3eda4e](d3eda4e))
@github-actions
Copy link

github-actions bot commented Jun 9, 2021

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants