Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect expo-config(MODULE_NOT_FOUND) error #61

Closed
josmithua opened this issue Aug 13, 2021 · 7 comments
Closed

Incorrect expo-config(MODULE_NOT_FOUND) error #61

josmithua opened this issue Aug 13, 2021 · 7 comments
Labels
bug Something isn't working

Comments

@josmithua
Copy link

Description of the bug

The extension is reporting expo-config(MODULE_NOT_FOUND) for all plugins that I specify in app.json

To Reproduce

  1. expo init
  2. Create app.plugin.js file with contents: module.exports = (config) => config;
  3. In app.json add expo.plugins property: "plugins": ["./app.plugin"],
  4. Notice error:
    Cannot find module '/Users/joshua/code/TestExpoApp/app.plugin.js' 
    expo-config(MODULE_NOT_FOUND)
    

Expected behavior

No error should appear

Actual behavior

Error appeared

Additional context

Name: Expo Tools
Id: bycedric.vscode-expo
Description: Expo tools for vscode
Version: 0.7.3
Publisher: Cedric van Putten
VS Marketplace Link: https://marketplace.visualstudio.com/items?itemName=byCedric.vscode-expo
@guyzmo
Copy link

guyzmo commented Aug 13, 2021

I reproduced that bug by launching a vscode here, and I had the same error. My local plugin works perfectly fine.
(though I cannot say I'm impacted, I'm a vim user 🤣 )

@tasugi
Copy link

tasugi commented Aug 20, 2021

I faced the same issue. I found that the version 0.7.1 does not have this bug.

@mbaker3
Copy link

mbaker3 commented Aug 23, 2021

While the error no longer shows in 0.7.1 the extension also doesn't seem to validate plugin paths at all.

0.7.2 seems to work as expected and correctly validates the plugin/module path.

Note: This issue also affects the Preview config and Preview modifier commands which don't correctly display the built time changes from the plugins. The plugin changes do work for actual builds.

@byCedric
Copy link
Member

This also happens for monorepos where the plugin package is installed in the root of the workspace.

@byCedric byCedric added the bug Something isn't working label Sep 15, 2021
@freeridre
Copy link

Hi,
I have the same problem. I have written it in expo’s forum

@byCedric
Copy link
Member

Fixed by #71, hopefully we can release it this week!

@byCedric
Copy link
Member

As mentioned in #71

🎉 This PR is included in version 0.7.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

If there is anything else, please let us know! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants