Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how to enable SKIP_WAL on put #17

Open
xiaoliangwu opened this issue Oct 18, 2019 · 2 comments
Open

how to enable SKIP_WAL on put #17

xiaoliangwu opened this issue Oct 18, 2019 · 2 comments

Comments

@xiaoliangwu
Copy link

Hi
We meet write bottleneck, and missing some data is acceptable in my project , so I think the better solution is to enable SKIP_WAL , but it seems it's not supported , could you help to add this feature ?

thanks a lot

xlwu

@moshewe
Copy link
Contributor

moshewe commented Oct 21, 2019

It isn't supported since Put doesn't pass on the durability arguments to the underlying thrift generated node.js implementation. See client.js:234.

You can make a PR with code that passes the durability arguments into the HBaseTypes.TPut constructor, that's supposed to do the trick.

@moshewe
Copy link
Contributor

moshewe commented Oct 21, 2019

Also, see the thrift file definitions for TDurability and how they are generated to make sure you pass along the right parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants