Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpublish 3.4.3, publish as 3.5.0 #1794

Closed
mcculloughsean opened this issue Oct 24, 2013 · 2 comments
Closed

Unpublish 3.4.3, publish as 3.5.0 #1794

mcculloughsean opened this issue Oct 24, 2013 · 2 comments

Comments

@mcculloughsean
Copy link

The upgrade to connect 2.10 is a breaking change. See senchalabs/connect#943

@jonathanong
Copy link
Member

the intended reason for that change is for a bug fix, thus the patch bump instead of the minor bump. if its intention were a new feature, then yes, this would make sense. but you were relying on a bug.

so far, it seems you expect the router to have precedence over the static middleware even though the router is placed after the static middleware in the stack. if it worked otherwise, it was a bug.

your redirect issue could be solved easily by setting redirect: false. if that doesn't work, it's a bug.

@dougwilson
Copy link
Contributor

Or by adding app.use(app.router) above the app.use(staticMiddleware) if you want the router to take precedence, of course.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants