Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to map out outdated translations #1480

Open
2 tasks
UlisesGascon opened this issue Apr 2, 2024 · 6 comments
Open
2 tasks

Proposal to map out outdated translations #1480

UlisesGascon opened this issue Apr 2, 2024 · 6 comments

Comments

@UlisesGascon
Copy link
Member

UlisesGascon commented Apr 2, 2024

In our recent TC meeting, we discussed the need for a more efficient method of detecting outdated translated versions of our documentation. Below is a proposal aimed at addressing this issue and enhancing the user experience for our contributors.

Assumptions

  • Typically, changes are made to the English version of the documentation first, without waiting for translations to be completed. (For example, see: PR #1474)
  • Our community is eager to assist with translations (Issue #1237), but it's challenging for them to initiate the process.
  • Identifying which parts of the documentation have changed and need updating in their respective translated versions is difficult, leading to outdated translations.

Workflow

I propose creating a GitHub Action similar to the one discussed in Issue #1479. This action would detect changes made in any version using regex for the paths. It would then add tags in the PR for other versions that need translation, such as needs fr translation and needs sp translation. This tagging system would enable us to easily identify closed PRs requiring translation. For instance, we could filter closed PRs for the French version using a tag-based search: French Version PRs.

If a change doesn't require translation, such as fixing a typo in the English text, we can simply remove the corresponding tags before merging the PR.

Next Steps

  • Develop a GitHub Action to support this workflow.
  • Update the CONTRIBUTING.md guide to incorporate this workflow.
@UlisesGascon UlisesGascon changed the title Proposal for mark outdated translations Proposal to map out outdated translations Apr 2, 2024
@UlisesGascon UlisesGascon pinned this issue Apr 2, 2024
@crandmck
Copy link
Member

crandmck commented Apr 8, 2024

Great idea! Keep in mind that the API doc is not translated, so this only applies to the rest of the doc.

@carlosstenzel
Copy link
Contributor

@crandmck @UlisesGascon @bjohansebas @chrisdel101

Hello team,

I developed a script that creates a page with translation statuses.

But :´( the action doesn't work

Captura de Tela 2024-08-30 às 21 02 22

I think it could be a configuration for action

Captura de Tela 2024-08-30 às 21 02 04

I forced the manual creation of the page, to view

https://deploy-preview-1586--expressjscom-preview.netlify.app/en/resources/status-translate

Would anyone like to help me develop this idea? or solve the action problem?

@bjohansebas
Copy link
Member

bjohansebas commented Aug 31, 2024

Maybe it could work to add these lines during the checkout in GitHub Actions, so it references the branch.

- uses: actions/checkout@v3
      with:
        fetch-depth: 0
        ref: ${{ github.event.pull_request.head.ref }}

edit: I saw that you tried that, I'll keep investigating.
edit: I've tested it in my repo (see https://github.com/bjohansebas/expressjs.com/pull/5), and with the suggested change, it works fine. If it doesn't work with these changes in the official repo, it might be a permissions issue.

@carlosstenzel
Copy link
Contributor

@bjohansebas thanks for the feedback, it's probably permissions. @crandmck can you help us?

@crandmck
Copy link
Member

crandmck commented Sep 2, 2024

It looks like @UlisesGascon did something very similar to this in #1514 ... Unless I'm misunderstanding.

For example, I notice that this PR I opened today automatically was tagged with numerous needs-translation-xx labels.

Can you guys clarify if there's a difference between this PR and what the above PR did?

@carlosstenzel
Copy link
Contributor

The permission to add labels or commits depends on who executes it. For you, write is allowed, for others it is only read.

Your
Captura de Tela 2024-09-02 às 20 04 22

other people
Captura de Tela 2024-09-01 às 21 53 48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants