Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace the use of github API with labeler in the translation pipeline #1571

Closed
bjohansebas opened this issue Aug 13, 2024 · 2 comments
Closed
Labels

Comments

@bjohansebas
Copy link
Member

We could use labeler instead of directly using the GitHub API. This would bring benefits, such as making it easier to manage the labels to be injected if certain content is modified. It wouldn't be limited to translations only; for example, it could handle if certain documentation for v3, v4, or v5 is edited.

Implementing it would help prevent errors like the one in #1553

It could be an improvement that i could implement.

@crandmck
Copy link
Member

It looks like the issue in #1553 was resolved. What are the pros and cons of using labeler vs GH API?

@bjohansebas
Copy link
Member Author

Before proposing this tool, I didn't fully understand how the workflow worked. Now that I’ve read how the workflow operates, I don't see much sense in this tool, other than making it easier to detect changes in the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants