fix ruby version in Netlify #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Closed
bjohansebas
force-pushed
the
fix-netlify-error
branch
from
716144d to
efe8f05
Compare
UlisesGascon
approved these changes
Aug 22, 2024
|
I will merge it as this will unblock previews and CI pipelines failing in many PRs |
chrisdel101
pushed a commit
to chrisdel101/expressjs.com
that referenced
this pull request
Nov 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After several attempts to fix this error and considering that it could be a version issue, as tried in PR (#1573) but in Docker, I noticed that Netlify uses an outdated default version. Although this change can be managed through environment variables, I don’t think it's best to handle it that way. Instead, it should be specified in a file so that administrators don’t have to manually change the version through the settings.
Resources:
https://answers.netlify.com/t/cant-deploy-with-ruby-3-1-2/55728
https://docs.netlify.com/configure-builds/available-software-at-build-time/
https://docs.netlify.com/configure-builds/manage-dependencies/#ruby
Close:
#1566
Edit: I just realized that the Docker configuration also needs to be fixed.
Edit: I'm not sure if these changes will work on GitHub Pages. If they don't work, it will be necessary to change the version using environment variables.
Edit: I have been testing in my repository, and GitHub Pages seems to work fine, so setting a specific Ruby version wouldn't be a problem.