make tests for custom token() usage

[bmeck]

Superseding #124

• fixes parsing of empty arguments via :x[]
• makes token functions always be given the same length of arguments

Makes tests for custom usage of morgan.token from reading the docs.

[dougwilson]

Awesome, will take a closer look soon :) A quick look shows that there are some comments from the previous PR that were missed on this one, so getting those addressed would help, otherwise I'll spend some time to write them back on this PR as well :) A few that jump out: #124 (comment) , #124 (comment) , #124 (comment) , #124 (comment) , #124 (comment) , #124 (comment) , #124 (comment) , #124 (comment)

[bmeck]

Pushed changes, but opposed to DRY change.

On Tue, Oct 11, 2016 at 9:48 PM, Douglas Wilson notifications@github.com
wrote:

Awesome, will take a closer look soon :) A quick look shows that there are
some comments from the previous PR that were missed on this one, so getting
those addressed would help, otherwise I'll spend some time to write them
back on this PR as well :) A few that jump out: #124 (comment)
#124 (comment) , #124
(comment)
#124 (comment) , #124
(comment)
#124 (comment) , #124
(comment)
#124 (comment) , #124
(comment)
#124 (comment) , #124
(comment)
#124 (comment) , #124
(comment)
#124 (comment) , #124
(comment)
#124 (comment)

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#127 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAOUo3ZvCkKTJu19X7a5d9cda9eoxAXSks5qzEplgaJpZM4KTpPP
.

[dougwilson]

but opposed to DRY change.

Please make the change; in the end, I have yo maintain the tests and the changes should be consistent with all the other code I am maintaining.

[bmeck]

@dougwilson going to simply drop this. done.