Modify bindings to generate an emscripten target #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JosiahParry
changed the title
CGMossa
approved these changes
May 3, 2024
There was a problem hiding this comment.
LGTM: One comment is, I thought the build.rs had to modified somehow. That it should be modified because otherwise it would actually not generate the bindings for emscripten, if it was asked to do so.
But what this does, is it provide a compatible cached emscripten bindings, so when using libR-sys without use-bindgen feature, it will use that to link.
So there is still an ambiguity here that we need to address.
|
Let us wait a little on merging this. Josiah and I have to do some diligence. |
|
Agreed. I'll move into draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR adds emscripten-wasm32 bindings enabling extendr to work with webr.
This PR modifies the yml to also generate emscripten bindings. We have tested and compiled
rsgeoto wasm using this approach.