Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing ... from rextendr::document into devtools::document #153

Closed
multimeric opened this issue Dec 4, 2021 · 4 comments
Closed

Comments

@multimeric
Copy link
Member

I've been hitting an issue where, when I run rextendr::document(), I get:

Error in getDLLRegisteredRoutines.DLLInfo(dll, addNames = FALSE) : 
  must specify DLL via a “DLLInfo” object. See getLoadedDLLs()

This issue is caused by roxygen, and has a long discussion here. The short solution is to simply use roxygenise(load = "source").

However, I can't use this load argument with rextendr::document. It would be nice if I could, for this reason. We could just forward all additional arguments to the underlying documentation function.

@clauswilke
Copy link
Member

Sounds reasonable. Feel free to submit a PR.

@multimeric
Copy link
Member Author

Ah, actually this would require using roxygen::roxygenize() as the underlying function, which is a bit trickier because we would lose all the nice devtools info messages.

@Ilia-Kosenkov
Copy link
Member

@multimeric, is it still a major problem? devtools::document() internally calls roxygen::roxygenize(), so in principle we can duplicate the logic of devtools::document() , but I am not a fan of this solution.

@Ilia-Kosenkov
Copy link
Member

I will close this since rextendr::document() is designed to closely follow devtools::document().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants