Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: return Extism error message regardless of the return code #86

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: return Extism error message regardless of the return code #86

merged 2 commits into from
Nov 21, 2024

Conversation

zshipko
Copy link
Contributor

@zshipko zshipko commented Nov 20, 2024

No description provided.

@zshipko zshipko requested a review from mhmd-azeez as a code owner November 20, 2024 21:03
nilslice
nilslice approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@nilslice nilslice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zshipko zshipko merged commit bef00f3 into main Nov 21, 2024
3 checks passed
@zshipko zshipko deleted the error-code branch November 21, 2024 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilslice nilslice nilslice approved these changes

@mhmd-azeez mhmd-azeez Awaiting requested review from mhmd-azeez mhmd-azeez is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zshipko @nilslice