Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: more consistent spelling of "color"/"colour" in help output #1243

Open
sodiboo opened this issue Nov 22, 2024 · 0 comments
Open

feat: more consistent spelling of "color"/"colour" in help output #1243

sodiboo opened this issue Nov 22, 2024 · 0 comments

Comments

@sodiboo
Copy link

sodiboo commented Nov 22, 2024

eza/src/options/help.rs

Lines 29 to 31 in 83ca7b3

--colo[u]r=WHEN when to use terminal colours (always, auto, never)
--colo[u]r-scale highlight levels of 'field' distinctly(all, age, size)
--colo[u]r-scale-mode use gradient or fixed colors in --color-scale (fixed, gradient)

The help text for --color and --color-scale-mode use different variations in spelling for their internal help text. It's not a problem that they aren't agnostic (i.e. i wouldn't expect them to say when to use termianl colo[u]rs), but it seems odd that they are using different variations. This should probably be fixed, so they use the same spelling.

Moreover, it is annoying that i can't grep for either spelling reliably. Consider replacing --colo[u]r=WHEN with --color=WHEN --colour=WHEN, or --{color,colour}=WHEN, or something similar that fully spells out both variants (and vice versa for the other two options of course). This ensures that grepping for either term will output all the relevant options, which may be useful to someone else in the future, saving them the few seconds of confusion i experienced prior to creating this issue

grepping the eza help output for color and colour with american and british spellings returns two different lines. there is a third color option that isn't returned by either. above is shown all three relevant lines, which ought to have been printed by the following two invocations
(all three invocations here should output the same three lines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant