bug: Obscure width bug

[cafkafk]

I'm adding this just so I don't forget about it.

Seems to occur around COL 399

Seems not to occur before COL 398

I don't have time to look more into this right now, and this probably will not matter in this decade, but it's still a bug.

[gierens]

It gets even weirder:

[PThorpe92]

So my initial thoughts are This
might very well fix (or I guess could even complicate) this and #129 ?

Not that it doesn't seem worth looking into... but @gierens I assume you are taking a look at the width issues?

[gierens]

So I looked into this, and traced it back to this: https://github.com/eza-community/eza/blob/main/src/output/grid_details.rs#L167-L177 ... Here it tries to find the largest number of columns where the grid still fits in the requested width.

It starts at 2 columns and ramps it up as long as the "supposed" width of the displayed grid is smaller than the console width. I say "supposed" because I'm pretty sure the values reported back by d.width() are off. In case of my screenshot above the loop ends up at 11 grid columns "supposedly" fitting into 482 terminal columns, which they obviously don't.

Since this d.width() is a term_grid function this is probably due to the one-off bug in it (ogham/rust-term-grid#15) referenced in the issue you mentioned. So I would agree that moving to the patched fork should probably fix this.

[gierens]

I also think that #129 is probably unrelated to this term-grid bug, but I will write more detailed comment about it in that issue.

[PThorpe92]

At the very least, I think substantial effort would be better spent on/after migration to uutils. I am surprised it's not on crates.io as it looks like it's the only one they haven't published.

[gierens]

I also think that #129 is probably unrelated to this term-grid bug, but I will write more detailed comment about it in that issue.

Confirmed, #129 is unrelated, just created a PR for that one: #136

[github-actions]

This issue is stale because it has been open for 30 days with no activity.

[github-actions]

This issue was closed because it has been inactive for 14 days since being marked as stale.