exclude filters .js output, but not .d.ts (plugin exclude vs. tsconfig exclude)

[sami616]

My plugin config :

    typescript({
      typescript: require('typescript'),
      exclude: ['**/*.stories.tsx', 'node_modules'],
    }),

My include/exclude in tsconfig

  "include": ["src/**/*", "typings/**/*"],
  "exclude": ["node_modules"]

Im seeing that the plugin is excluding the stories files from my output, however .d.ts files for them are stll being outputted:

Version:

"rollup-plugin-typescript2": "^0.27.0",

[ajayvarghese]

I have this issue with rollup-plugin-typescript2@0.27.1 typescript@3.9.2. But works after downgrading typescript to 3.8.3.

[agilgur5]

I took a look at this issue again and realized that my previous comment was incorrect (and I've hidden it now that I have some maintainer permissions, was just a contributor before). OP is using the plugin exclude filter, not tsconfigDefaults or tsconfigOverrides, so this is different from #226 and not a duplicate.

Your tsconfig would have to exclude the stories too for this to work. You can either have two separate tsconfigs (e.g. I use one for type-checking everything and one for building), or you can use tsconfigOverrides to add the stories to your tsconfig excludes

[agilgur5]

This should be fixed by #347

Once that's merged and released, the workaround of using separate tsconfig excludes should no longer be necessary.

[agilgur5]

#347 has been released in 0.33.0