Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noEmitOnError: false seems to be ignored -- use plugin option abortOnError #62

Closed
TobiaszCudnik opened this issue Mar 1, 2018 · 2 comments
Labels
kind: support Asking for support with something or a specific use case solution: already possible This is already possible / this feature already exists solution: invalid This doesn't seem right

Comments

@TobiaszCudnik
Copy link

TobiaszCudnik commented Mar 1, 2018

What happens and why it is wrong

Semantic errors result in no emit. Adding noEmitOnError: false doesn't help.

Error:

[!] (rpt2 plugin) Error: /Users/.....ts(1286,2): semantic error TS2300 Duplicate identifier 'on'.

Versions

  • typescript: 2.7.2
  • rollup: 0.51.8
  • rollup-plugin-typescript2: 0.11.1

rollup.config.js

config.plugins[0] = typescript({
  target: 'es6',
  isolatedModules: true,
  module: 'es6',
  typescript: tsc,
  noEmitOnError: false
})

tsconfig.json

{
    "compilerOptions": {
        "target": "es6",
        "module": "commonjs",
        "declaration": true,
        "removeComments": false,
        "lib": ["es2017", "dom"],
        "sourceMap": true,
        "strict": true,
        "suppressImplicitAnyIndexErrors": true,
        "preserveConstEnums": true,
        "outDir": "build"
    },
    "include": [
        "src/**/*"
    ]
}

How can I force it to pass through? ts-ignore all of them? Fixing those errors is not an option at the moment. Thanks.

@ezolenko
Copy link
Owner

ezolenko commented Mar 1, 2018

There is abortOnError option, set to true by default. You can either set it to false and ignore printed errors, or you can set check to false and avoid all checking entirely.

Also take a look at readme for options the plugin takes, you can't pass in tsconfig options directly like you could in the original.

@TobiaszCudnik
Copy link
Author

Thanks! That's exactly what I was looking for, check: false did the job in my case. I guess I was going through the readme too quickly... ;)

@agilgur5 agilgur5 added solution: invalid This doesn't seem right kind: support Asking for support with something or a specific use case solution: already possible This is already possible / this feature already exists labels May 8, 2022
@agilgur5 agilgur5 changed the title noEmitOnError: false seems to be ignored noEmitOnError: false seems to be ignored -- use plugin option abortOnError May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: support Asking for support with something or a specific use case solution: already possible This is already possible / this feature already exists solution: invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants