From e766878c07435ee29997e9d4e704fd8235c9cce6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Parafi=C5=84ski?= Date: Thu, 2 Dec 2021 08:57:57 +0100 Subject: [PATCH] IBX-1543: Replaced deprecated twig functions (#29) * IBX-1543: Replaced ez_content_name function * IBX-1543: Added deprecation for ez_render function * IBX-1543: Added deprecation for ez_render_*_query function * IBX-1543: Replaced & deprecate ez_render_field function * IBX-1543: Replaced ez_field_value function * IBX-1543: Replaced ez_field function * IBX-1543: Depreceted ez_field_name function * IBX-1543: Depreceted ez_field_description function * IBX-1543: Replaced ez_field_is_empty function * IBX-1543: Replaced image related twig funtions * IBX-1543: Replaced URL twig functions * IBX-1543: Replaced rest of core extensions and filters function * IBX-1543: Dropped removed `getName` function implementation * IBX-1543: Replaced global `ezplatform` variable * IBX-1543: Fixed code style * IBX-1543: Added deprecation messeges to unit tests --- .../FieldDefinitionSettingsTemplates.php | 2 +- .../Configuration/Parser/FieldTemplates.php | 2 +- .../Resources/views/content_fields.html.twig | 40 +++++----- .../default/content/asset_image.html.twig | 4 +- .../views/default/content/embed.html.twig | 6 +- .../default/content/embed_image.html.twig | 4 +- .../default/content/embed_inline.html.twig | 6 +- .../views/default/content/full.html.twig | 4 +- .../views/default/content/line.html.twig | 4 +- .../default/content/text_linked.html.twig | 4 +- .../Core/Resources/views/pagelayout.html.twig | 4 +- .../View/ParameterProviderInterface.php | 2 +- .../Twig/Extension/ContentExtension.php | 68 +++++++++++++--- .../Twig/Extension/CoreExtension.php | 16 ++-- .../Extension/DataAttributesExtension.php | 9 +++ .../Extension/FieldRenderingExtension.php | 49 ++++++++---- .../Twig/Extension/FileSizeExtension.php | 23 +++--- .../Twig/Extension/ImageExtension.php | 23 ++++-- .../Extension/QueryRenderingExtension.php | 52 ++++++++---- .../Twig/Extension/RenderContentExtension.php | 9 +++ .../Twig/Extension/RenderExtension.php | 9 +++ .../Extension/RenderLocationExtension.php | 9 +++ .../Twig/Extension/RoutingExtension.php | 39 +++++++-- .../content_functions/ibexa_content_name.test | 35 ++++++++ .../content_functions/ibexa_field.test | 49 ++++++++++++ .../ibexa_field_description.test | 49 ++++++++++++ .../content_functions/ibexa_field_name.test | 49 ++++++++++++ .../content_functions/ibexa_field_value.test | 49 ++++++++++++ .../ibexa_is_field_empty.test | 80 +++++++++++++++++++ .../ibexa_render_field.test | 73 +++++++++++++++++ .../ibexa_render_field_exception.test | 23 ++++++ ...ibexa_render_fielddefinition_settings.test | 25 ++++++ .../filters/ez_data_attributes_serialize.test | 2 + .../ibexa_data_attributes_serialize.test | 37 +++++++++ .../functions/ez_file_size/ez_file_size.test | 13 +++ .../ez_file_size/ibexa_file_size.test | 65 +++++++++++++++ .../ibexa_render_content_query.test | 36 +++++++++ .../ibexa_render_content_query_esi.test | 36 +++++++++ .../ibexa_render_location_query.test | 36 +++++++++ .../ibexa_render_location_query_esi.test | 36 +++++++++ .../_fixtures/routing_functions/ez_path.test | 16 ++++ .../_fixtures/routing_functions/ez_route.test | 4 + .../_fixtures/routing_functions/ez_url.test | 16 ++++ .../routing_functions/ibexa_path.test | 48 +++++++++++ .../routing_functions/ibexa_route.test | 21 +++++ .../routing_functions/ibexa_url.test | 48 +++++++++++ 46 files changed, 1118 insertions(+), 116 deletions(-) create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/content_functions/ibexa_content_name.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/content_functions/ibexa_field.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/content_functions/ibexa_field_description.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/content_functions/ibexa_field_name.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/content_functions/ibexa_field_value.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/content_functions/ibexa_is_field_empty.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/field_rendering_functions/ibexa_render_field.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/field_rendering_functions/ibexa_render_field_exception.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/field_rendering_functions/ibexa_render_fielddefinition_settings.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/filters/ibexa_data_attributes_serialize.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/functions/ez_file_size/ibexa_file_size.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/query_rendering_functions/ibexa_render_content_query.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/query_rendering_functions/ibexa_render_content_query_esi.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/query_rendering_functions/ibexa_render_location_query.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/query_rendering_functions/ibexa_render_location_query_esi.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/routing_functions/ibexa_path.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/routing_functions/ibexa_route.test create mode 100644 tests/lib/MVC/Symfony/Templating/Twig/Extension/_fixtures/routing_functions/ibexa_url.test diff --git a/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldDefinitionSettingsTemplates.php b/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldDefinitionSettingsTemplates.php index 723c4ee39c..e8d5932a82 100644 --- a/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldDefinitionSettingsTemplates.php +++ b/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldDefinitionSettingsTemplates.php @@ -9,7 +9,7 @@ class FieldDefinitionSettingsTemplates extends Templates { public const NODE_KEY = 'fielddefinition_settings_templates'; - public const INFO = 'Template settings for field definition settings rendered by the ez_render_field_definition_settings() Twig function'; + public const INFO = 'Template settings for field definition settings rendered by the ibexa_render_field_definition_settings() Twig function'; public const INFO_TEMPLATE_KEY = 'Template file where to find block definition to display field definition settings'; } diff --git a/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldTemplates.php b/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldTemplates.php index 23e76a9fa9..8c796d684b 100644 --- a/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldTemplates.php +++ b/src/bundle/Core/DependencyInjection/Configuration/Parser/FieldTemplates.php @@ -9,7 +9,7 @@ class FieldTemplates extends Templates { public const NODE_KEY = 'field_templates'; - public const INFO = 'Template settings for fields rendered by the ez_render_field() Twig function'; + public const INFO = 'Template settings for fields rendered by the ibexa_render_field() Twig function'; public const INFO_TEMPLATE_KEY = 'Template file where to find block definition to display fields'; } diff --git a/src/bundle/Core/Resources/views/content_fields.html.twig b/src/bundle/Core/Resources/views/content_fields.html.twig index 28dac2393e..0b0041d141 100644 --- a/src/bundle/Core/Resources/views/content_fields.html.twig +++ b/src/bundle/Core/Resources/views/content_fields.html.twig @@ -66,7 +66,7 @@ {% block ezdatetime_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %} {% if fieldSettings.useSeconds %} {% set field_value = field.value.value|format_datetime( 'short', 'medium', locale=parameters.locale ) %} {% else %} @@ -79,7 +79,7 @@ {% block ezdate_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %} {% set field_value = field.value.date|format_date( 'short', locale=parameters.locale ) %} {{ block( 'simple_block_field' ) }} {% endif %} @@ -88,7 +88,7 @@ {% block eztime_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %} {% if fieldSettings.useSeconds %} {% set field_value = field.value.time|format_time( 'medium', locale=parameters.locale, timezone='UTC' ) %} {% else %} @@ -101,7 +101,7 @@ {% block ezemail_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %} {% set field_value = field.value.email %} {{ field.value.email }} {% endif %} @@ -110,7 +110,7 @@ {% block ezinteger_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %} {% set field_value = field.value.value %} {{ block( 'simple_inline_field' ) }} {% endif %} @@ -120,7 +120,7 @@ {# @todo: handle localization #} {% block ezfloat_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %} {% set field_value = field.value.value %} {{ block( 'simple_inline_field' ) }} {% endif %} @@ -129,7 +129,7 @@ {% block ezurl_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %} {{ field.value.text ? field.value.text : field.value.link }} {% endif %} @@ -145,7 +145,7 @@ {% block ezkeyword_field %} {% apply spaceless %} - {% if not ez_field_is_empty( content, field ) %} + {% if not ibexa_field_is_empty( content, field ) %}