Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved code related to EZP-29139 #2454

Merged
merged 2 commits into from
Sep 24, 2018

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Sep 21, 2018

Question Answer
JIRA issue Follow-up on EZP-29139
Bug/Improvement yes
New feature no
Target version 6.x
BC breaks no
Tests pass yes
Doc needed no

This PR introduces improvements to parts of the code related to #2423 changes.

TODO:

  • Improve query selection logic in Content Gateway implementation
  • Improve PhpDoc on the prototypes in the SPI URLAlias Handler.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@alongosz
Copy link
Member Author

Thanks 🎉
Merging, no QA needed as changed piece of code is rather well covered by integration tests.

@alongosz alongosz merged commit b4417cd into ezsystems:6.7 Sep 24, 2018
@alongosz alongosz deleted the ezp-29139-improvements branch September 24, 2018 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants