EZP-30573: As a Developer I want to filter by status when using ContentService::loadVersions method #2652
Conversation
kmadejski
force-pushed
the
ezp_30573_version_status
branch
from
d388d34
to
3b3f895
Compare
|
@alongosz I totally understand your point of view, even agree with it, but my motivation for this PR is a customer's report complaining about the performance of |
kmadejski
force-pushed
the
ezp_30573_version_status
branch
from
3b3f895
to
90c2aa1
Compare
| * | ||
| * @return \eZ\Publish\API\Repository\Values\Content\VersionInfo[] Sorted by creation date | ||
| */ | ||
| public function loadVersions(ContentInfo $contentInfo) | ||
| public function loadVersions(ContentInfo $contentInfo, $status = null) |
There was a problem hiding this comment.
I'm wondering about introducing struct representing "loading options" here: In the feature, we might need to support other filters (e.g. creator) and pagination
There was a problem hiding this comment.
I agree. It would be nice to have something like that, but honestly, I really don't want to do anything more than what is necessary for improving the mentioned command.
Good idea, but it should go to master then 😉
There was a problem hiding this comment.
And we don't currently do struct for loading options, we did for a bit on load content, but we dropped it when we found a way around.
…ntService::loadVersions method
kmadejski
force-pushed
the
ezp_30573_version_status
branch
from
9924af6
to
275bed2
Compare
…g ContentService::loadVersions method
|
@alongosz I rebased it against 7.5 as we discussed |
| * | ||
| * @param \eZ\Publish\API\Repository\Values\Content\ContentInfo $contentInfo | ||
| * @param null|int $status |
There was a problem hiding this comment.
nitpick : int|null,
this is covered by new cs-fixer afair.
This have multiple occurrence, btw.
|
@micszo we need round of QA here. |
|
Merged up to |
7.5/masterThis PR introduces the new
$statusargument forContentService::loadVersionsmethod.For more information please refer to JIRA ticket.
TODO:
$ composer fix-cs).