Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EZP-29591: deprecated PHP4 style class constructor #16

Merged

Conversation

fwoldt
Copy link
Contributor

@fwoldt fwoldt commented Sep 6, 2018

Use of deprecated PHP4 style class constructor is not supported since PHP 7.

Use of deprecated PHP4 style class constructor is not supported since PHP 7.
Use of deprecated PHP4 style class constructor is not supported since PHP 7
Copy link
Contributor

@andrerom andrerom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@wizhippo / @emodric Looks ok for you too?

@emodric
Copy link
Contributor

emodric commented Sep 7, 2018

👍

1 similar comment
@wizhippo
Copy link

wizhippo commented Sep 7, 2018

+1

@andrerom
Copy link
Contributor

andrerom commented Sep 17, 2018

@glye will this or ezsystems/ezwt#18 imply we need to do package updates as well?

EDIT: I guess the answer is "optional" as this is not in regards to setup wizard code, so people will be able to run install and afterwards they can get fixes like this via composer once we tag it.

@andrerom andrerom merged commit 190c645 into ezsystems:master Sep 17, 2018
andrerom pushed a commit that referenced this pull request Sep 17, 2018
* Fix: deprecated PHP4 style class constructor

Use of deprecated PHP4 style class constructor is not supported since PHP 7.

* Fix: deprecated PHP4 style class constructor

Use of deprecated PHP4 style class constructor is not supported since PHP 7

(cherry picked from commit 190c645)
@glye
Copy link
Member

glye commented Sep 18, 2018

Yes, this is fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants