Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-skip doesn't work anymore #246

Open
alangpierce opened this issue Apr 11, 2024 · 2 comments
Open

--no-skip doesn't work anymore #246

alangpierce opened this issue Apr 11, 2024 · 2 comments

Comments

@alangpierce
Copy link

I was seeing ghstack skip some PRs that I wanted to update, so I tried running --no-skip on ghstack 0.9.3, but it still skipped the PRs. From a quick look through the code, it looks like maybe --no-skip support was removed by accident when reworking the code for 0.9.0.

@alangpierce
Copy link
Author

For context on why I wanted --no-skip, it can come up when merging multiple PRs in a row with nobody else merging changes in between. Normally I land the bottom PR by updating the base branch and merging, then I rebase and ghstack so the new bottom PR is based off of the newly-updated default branch. If nobody else has landed anything during this time, though, the second ghstack is treated as a no-op, so I don't get an updated base. The workaround has been to run ghstack with --no-skip to ensure the base gets updated.

@ezyang
Copy link
Owner

ezyang commented Apr 11, 2024

Oops. I thought I had fixed this bug but apparently not. Thanks for the report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants