Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghstack submit --update-fields created a new pull request if the ghstack info is damaged or missing #252

Open
rec opened this issue Jun 19, 2024 · 1 comment

Comments

@rec
Copy link

rec commented Jun 19, 2024

This might not be expected behavior. Two other possibilities are that ghstack submit --update-fields fails if the ghstack info in the commit message is damaged or missing, or to create another flag --update-only/-U, with this behavior.

I'd be willing to submit a pull request for either one of these behaviors if there were interest.

This happened when I restored my ghstack info from a branch as:

    ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
    Pull Request resolved: #128416

instead of

    ghstack-source-id: de78c83d0763391c27c41501f614fafd49c9395c
    Pull Request resolved: https://github.com/pytorch/pytorch/pull/128416
@ezyang
Copy link
Owner

ezyang commented Jun 19, 2024

It seems fine to have update fields chicken out if it thinks it needs to make a new PR. Send a patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants