Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable .ghstackrc location? #260

Closed
xiaohan-xue opened this issue Oct 10, 2024 · 4 comments
Closed

Configurable .ghstackrc location? #260

xiaohan-xue opened this issue Oct 10, 2024 · 4 comments

Comments

@xiaohan-xue
Copy link
Contributor

xiaohan-xue commented Oct 10, 2024

Hello!

How would people feel about allowing the location of .ghstackrc to be optionally read from an environment variable? We're using ghstack inside docker containers, where a mounted volume holds various config files to persist them across container rebuilds, and it would be nice if we could specify a config file location for ghstack so we could plop it into the volume instead of having to bind mount the ~/.ghstackrc location.

Would be more than happy to open a PR changing

def read_config(
if it's just that straightforward!

Thanks for making this awesome tool :3

@ezyang
Copy link
Owner

ezyang commented Oct 12, 2024

sure, send a patch

@xiaohan-xue
Copy link
Contributor Author

thanks!! put up #261

@xiaohan-xue
Copy link
Contributor Author

xiaohan-xue commented Oct 21, 2024

hi again~ would really appreciate if anyone with permissions could run poetry publish --build so that 0.9.4 is pullable/this can be closed, whenever is convenient

tysm in advance ;-;

@xiaohan-xue
Copy link
Contributor Author

saw that this is now available, thanks so much!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants