Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exponential Backoff instead of "cowardly limit" of 8 stacked PRs? #267

Open
bdaz opened this issue Nov 16, 2024 · 1 comment
Open

Exponential Backoff instead of "cowardly limit" of 8 stacked PRs? #267

bdaz opened this issue Nov 16, 2024 · 1 comment

Comments

@bdaz
Copy link

bdaz commented Nov 16, 2024

Love ghstack, but frequently running into Cowardly refusing to handle a stack with more than eight PRs. You are likely to get rate limited by GitHub if you try to create or manipulate this many PRs. You can bypass this throttle using --force

Force obviously works—until you are in fact rate limited (and then all hell breaks loose and neither ghstack nor myself have any idea what state things are in).

Seems like a typical case for using exponential backoff if we're getting 429s from GitHub's API. Consider this a feature request!

@ezyang
Copy link
Owner

ezyang commented Nov 18, 2024

I took the opportunity read the GitHub docs more carefully and I saw this: https://docs.github.com/en/rest/using-the-rest-api/rate-limits-for-the-rest-api?apiVersion=2022-11-28#exceeding-the-rate-limit

So actually we know exactly how long we should wait before we try again. Seems like a simple patch to add. Maybe send a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants